-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/migrate out of antd #34
Closed
+3,746
−5,497
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
53a62d1
feat: replace react-intl with linguijs
aseer-ws ad21166
chore: remove babel-plugin-formatjs
aseer-ws 8802acf
chore: move code into src directory
aseer-ws bbce507
chore: refactor redux toolkit implementation
aseer-ws 5e4f7bc
fix: pull request template file location
aseer-ws fea1f4e
chore: remove redundant store jest mock
aseer-ws 9dc9369
chore: switch to ducanh2912/next-pwa from next-pwa
aseer-ws 2ed42e6
chore: update next-redux-wrapper usage
aseer-ws a63ae4b
chore: update jest snaphots
aseer-ws 517e9c3
fix: double render due to wrong assertion
aseer-ws 9f06ddc
chore: remove unused imports
aseer-ws deed1bb
chore: mui emotion integration
aseer-ws 6e76973
Merge branch 'main' of github.com:wednesday-solutions/next-bulletproo…
apurv-wednesday b8c1733
feat: update sonar
apurv-wednesday 1add7c9
Merge branch 'feat/chore-reduce-bundle' of github.com:wednesday-solut…
apurv-wednesday 546c37d
feat: add lighthouse conf
apurv-wednesday 2958741
fix: update snapshots
apurv-wednesday 2a52566
fix: code smells
apurv-wednesday 24213b2
feat: add jest annotations
apurv-wednesday File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ jobs: | |
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [18.x] | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
@@ -31,16 +31,7 @@ jobs: | |
|
||
- name: Build Project | ||
run: yarn build | ||
|
||
# commenting for now to make CI green , will try this | ||
# - name: run Lighthouse CI | ||
# run: | | ||
# yarn global add @lhci/[email protected] | ||
# lhci autorun --collect.staticDistDir | ||
|
||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
|
||
- uses: sonarsource/sonarqube-scan-action@master | ||
env: | ||
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: Jest Coverage Report with Annotations (CI) | ||
on: | ||
pull_request: | ||
branches: [main] | ||
push: | ||
branches: [main] | ||
jobs: | ||
coverage_report: | ||
name: Jest Coverage Report | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
cache: 'yarn' | ||
|
||
# could not find the threshold value in jest.config.js | ||
# therefore hardcoded for now | ||
# - name: Get Threshold | ||
# id: threshold | ||
# uses: notiz-dev/github-action-json-property@release | ||
# with: | ||
# path: 'jest.config.js' | ||
# prop_path: 'coverageThreshold.global.statements' | ||
|
||
- name: Install dependencies | ||
run: yarn | ||
|
||
- name: Test and generate coverage report | ||
uses: artiomtr/[email protected] | ||
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
# threshold: ${{steps.threshold.outputs.prop}} | ||
package-manager: yarn | ||
custom-title: Jest Coverage Report |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: CI | ||
on: | ||
pull_request: | ||
branches: [main] | ||
push: | ||
branches: [main] | ||
jobs: | ||
lhci: | ||
name: Lighthouse | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
ref: ${{ github.event.pull_request.head.sha }} | ||
- name: Use Node.js 20.x | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 20.x | ||
- name: yarn install and build | ||
run: | | ||
yarn install | ||
yarn build | ||
- name: run Lighthouse CI | ||
run: | | ||
yarn global add @lhci/cli | ||
lhci autorun | ||
env: | ||
LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing the commented-out code related to dynamic threshold fetching or implement it to avoid hardcoding values, which can enhance maintainability.