-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-intl with lingui #33
Conversation
WalkthroughThe project has undergone a significant transformation with updates encompassing ESLint and Jest configurations, migration from Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (4)
README.md (4)
Line range hint
48-48
: Ensure markdown link is correctly closed for Redux Toolkit.- [Redux Toolkit](https://redux-toolkit.js.org/ + [Redux Toolkit](https://redux-toolkit.js.org/)
Line range hint
73-73
: Ensure markdown link is correctly closed for Api Sauce.- [Api Sauce](https://github.com/infinitered/apisauce/ + [Api Sauce](https://github.com/infinitered/apisauce/)
Line range hint
113-113
: Correct the spelling of "GitHub" and remove extra whitespace.- CI/CD using Github Actions. The CI pipeline has the following phases + CI/CD using GitHub Actions. The CI pipeline has the following phases
Line range hint
167-172
: Consider using arrows to clearly indicate alias mappings.- @features -> features/ - @slices -> store/slices/ - @store -> store/ - @common -> common/ - @themes -> themes/ - @utils -> utils/ - @containers -> containers/ + @features -> features/ + @slices -> store/slices/ + @store -> store/ + @common -> common/ + @themes -> themes/ + @utils -> utils/ + @containers -> containers/
@@ -41,7 +41,7 @@ An enterprise Next.js template application based on bulletproof architecture sho | |||
- API calls using `api-sauce` | |||
- Styling using `styled-components` | |||
- Reusing components from Ant design | |||
- Translations using `react-intl` | |||
- Translations using `lingui` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update documentation to reflect the transition from react-intl
to lingui
.
- Translations using `lingui`
+ Translations previously handled by `react-intl` are now managed using `lingui`.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- Translations using `lingui` | |
Translations previously handled by `react-intl` are now managed using `lingui`. |
|
||
- Translations using [React Intl](https://github.com/formatjs/react-intl) | ||
- Translations using [Lingui](https://lingui.dev/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure markdown link is correctly closed for Lingui.
- [Lingui](https://lingui.dev/
+ [Lingui](https://lingui.dev/)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- Translations using [Lingui](https://lingui.dev/) | |
- Translations using [Lingui](https://lingui.dev/) |
Analysis Details4 IssuesCoverage and DuplicationsProject ID: wednesday-solutions_next-bulletproof-ts_AY6yu6eKB2n8RRmGoUz4 |
Summary by CodeRabbit
New Features
lingui
for improved internationalization, replacingreact-intl
.Clickable
,Meta
, andEmptyResult
for enhanced UI interactions and metadata handling.Refactor
nextJest
for Jest configuration and updated test setups._app.tsx
and testing utilities.Bug Fixes
Documentation
Chores
.gitignore
andpackage.json
to support new configurations and dependencies.Style