Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): placeholderHandler do not trigger properly #202

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix(core): placeholderHandler do not trigger properly #202

merged 2 commits into from
Oct 22, 2024

Conversation

SgLy
Copy link
Contributor

@SgLy SgLy commented Oct 21, 2024

  1. placeholderHandlerRemover do not initialized properly for Component
  2. placeholderHandlerRemover may be missed if a component detached before it is attached
  3. ComponentWaitingList's remove may be called during its own call

@SgLy SgLy added bug Something isn't working module:core labels Oct 21, 2024
@SgLy SgLy requested a review from LastLeaf October 21, 2024 11:18
@SgLy SgLy self-assigned this Oct 21, 2024
@LastLeaf LastLeaf merged commit 9f9ffd8 into wechat-miniprogram:master Oct 22, 2024
4 checks passed
@SgLy SgLy mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LastLeaf LastLeaf Awaiting requested review from LastLeaf

Assignees

@SgLy SgLy

Labels
bug Something isn't working module:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgLy @LastLeaf