-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branding updates, asset referencing scheme & Shoelace icons #292
Conversation
- Missing 3D manifest icons (WIP!)
Adds ~assets directory, duped the setup in Browsertrix
Mirrors Browsertrix, nearly all of this was copied from there! - Adds custom app icon library - Adds the shoelace base path icon library - Sets up Webpack to copy shoelace assets and custom icon library assets - Sets up Webpack to import SVGs, WOFF files, TTF files, and WEBP files as paths and not data - Breaks everything that currently does this! 🫠
- Replaces almost every instance of font awesome icons in the codebase with shoelace icons (Bootstrap) - Adds the new brand assets! Replaces font awesome icons with `img` tags - Deletes all the old SVG imports, uses the new ones! - Removes the SVG loading animation - This will return at some point and it will be cool! I promise! - Minor nav bar icon grouping changes based on mockups - Navigation controls are now all on the left! Full screen has been moved to the right.
Caveats: Still missing the service worker page
- Accessibility improvements
- Changes the theme colour to be flush with the new white application bar
There's no way to actually load new web archives when this is hidden
- Updates help text with usage instructions - Adds copy button content description
This is used elsewhere, not a 1 line fix.
- Replaces the last `fa-icon` with an image and the new asset linking import -
- In line with when it shows and hides in the URL bar
- Fixes typo in fullscreen icon button name
Keeps bootstrap icons in the embed receipt.
@ikreymer Have reverted to Fontawesome and also updated to Fontawesome v6. |
Can't have a double chevron, but this is close enough!
@@ -741,18 +713,15 @@ export class ReplayWebApp extends LitElement { | |||
IS_APP | |||
? html` | |||
<p> | |||
ReplayWeb.page App is a standalone app for Mac, | |||
Windows and Linux that loads web archive files | |||
ReplayWeb.page is a standalone app for Mac, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is less clear, 'archived items' is what we call things in our app, but what we are dealing with is allowing users to load web archive files, which we then refer to as archived items. In general, archived items could be anything, not related to web archives
is a browser-based viewer that loads web archive | ||
files provided by the user and renders them for | ||
replay in the browser. | ||
ReplayWeb.page is a browser-based viewer that loads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, let's revert this change. The link is useful for opening a link to our site when using the embedded mode.
Closing this PR, making a new one |
Fixes #291
Changes
fa-icon
addssl-icon
Changes icons to align with ReplayWebpage 2.0 mockups<img src=""/>
attribute.Caveats
brandLockupColor
andrwpLogo
but I don't know if we have that available to us in JS? Pls advise <3Screenshots!
New VS old mobile menus
App icon on the service worker broken page
App icons in the embed
New macOS app icon!