Typescript conversion (second attempt) #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Merged
|
Closing in favor of #257 (third attempt!) |
ikreymer
added a commit
that referenced
this pull request
Oct 17, 2024
- Update all of archiveweb.page to use TypeScript * Convert entire project to TS using some tools from https://github.com/stripe-archive/flow-to-typescript-codemod * Set up ESLint with rules from replaywebpage, and autofix a bunch of things * Run format + lint on all files * Remove checked-in built files * Replaces outdated node-sass with sass - Update dependencies to wabac.js 2.20.0 and awp-sw 0.5.0, also updated to TS - App: fixes for opening links in new window - Some improvements to embed viewer, additional customizations, additional event messages passed from iframe - Supersedes PR #228 --------- Co-authored-by: emma <[email protected]> Co-authored-by: Henry Wilkinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the codebase to Typescript!
Closes #198
Changes
node-sasswithsassTesting
Merge Blockers
replaywebpagepublished on NPM2.0.0branch published to NPM2.1.xpublished to NPM