Fix possible double slashs when dynamicPublicPath #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Hi,
Thanks for this package!
I'm in a situation where a tool I can't control set my publicPath from config, and add a
/
to it. In fact webpack recommends to do that:However the HMR path also starts with a
/
, and all the default paths and example of this package!With theses both slashes, when in case of
dynamicPublicPath: true
, we end to apublicPath//path
path.This little PR just fixes that by replacing all
//
with/
in the paths concatenation.Thanks,
Mathieu.