Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disconnect on event source wrapper #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clarkdo
Copy link

@clarkdo clarkdo commented Oct 6, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add disconect on EventSourceWrapper for making close eventSource manually possible.

Breaking Changes

Additional Info

@glenjamin
Copy link
Collaborator

This code appears correct, but could you describe a use-case which would motivate doing this?

@clarkdo
Copy link
Author

clarkdo commented Oct 6, 2019

My case is that I want to close connection if the browser tab is hidden or minimized and refresh page when tab gets activated again for preventing reaching connection limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants