Make qoute approving intuitive #5163
Open
+29
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jennymul
force-pushed
the
make-qoute-approving-intuitive
branch
from
4557de4
to
a889d7f
Compare
norbye
reviewed
Nov 6, 2024
| @@ -30,6 +30,7 @@ const Quote = ({ | |||
| const fetchingEmojis = useAppSelector((state) => state.emojis.fetching); | |||
|
|
|||
| const [deleting, setDeleting] = useState(false); | |||
| const [pippi, setPippi] = useState(true); | |||
ivarnakken
requested changes
Nov 10, 2024
| {!quote.approved && pippi ? ( | ||
| <Dropdown.ListItem> | ||
| <button onClick={() => dispatch(approve(quote.id))}> | ||
| {'Godkjenn'} |
There was a problem hiding this comment.
Suggested change
| {'Godkjenn'} | |
| Godkjenn |
| {quote.approved ? 'Fjern godkjenning' : 'Godkjenn'} | ||
| </button> | ||
| </Dropdown.ListItem> | ||
| {!quote.approved && pippi ? ( |
There was a problem hiding this comment.
Suggested change
| {!quote.approved && pippi ? ( | |
| {!quote.approved ? ( |
?
| </button> | ||
| </Dropdown.ListItem> | ||
| ) : ( | ||
| <div></div> |
There was a problem hiding this comment.
Instead of using a ternary, just use && so that we don't need empty divs like this in the dom
There was a problem hiding this comment.
Again, not relevant to this PR hehe
ivarnakken
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove "Fjern godkjenning" as an option when a qoute is approved. When trying to delete a qoute, remove "Godkjenn" when "Er du sikker?" comes up.
Changes look good on both light and dark theme.
Changes look good with different viewports (mobile, tablet, etc.).
Changes look good with slower Internet connections.
I have thoroughly tested my changes.