Remove duplicate settings button #5161
Open
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jennymul
force-pushed
the
fix-duplicate-settings-button
branch
from
a705278
to
4a45f63
Compare
ivarnakken
reviewed
Nov 6, 2024
| > | ||
| <Icon | ||
| iconNode={<SettingsIcon />} | ||
| size={22} |
There was a problem hiding this comment.
22 is a bit large when it is inside a button - perhaps we could do something like 19 (like we do for most other buttons with icons)
| iconNode={<SettingsIcon />} | ||
| size={22} | ||
| className={styles.settingsIcon} | ||
| />{' '} |
falbru
approved these changes
Nov 6, 2024
Viljen789
reviewed
Nov 9, 2024
eikhr
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please write a summary of the changes, and please include relevant motivation and context. Remember to label your pull request properly; e.g. bug-fix, new-feature or docs.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Caution
Make sure your images do not contain any real user information.
Testing