Improve skeleton components on event detail page #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eikhr
requested review from
norbye,
itsisak,
falbru,
ivarnakken,
jonasdeluna,
Viljen789 and
viljeno
eikhr
force-pushed
the
improve-event-page-skeleton
branch
from
8707d58
to
5cd5aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More fine-grained control over what components are shown as skeletons. See images below.
This page could still use a bit more work to make the skeletons actually match the real components.
Result
Caution
Make sure your images do not contain any real user information.
Event page entered from the frontpage:
Event with registration
Testing
I have loaded a bunch of events a bunch of times, and it looks less wrong than it did before:)
Resolves ABA-1164