Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update achievement styling to be better #5139

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

jonasdeluna
Copy link
Member

@jonasdeluna jonasdeluna commented Nov 2, 2024

Description

Changed achievement profile view from flex to grid

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Before After

Testing

  • I have thoroughly tested my changes.

Tested manually

Resolves ... (either GitHub issue or Linear task)

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 9:01pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Nov 2, 2024
@jonasdeluna jonasdeluna marked this pull request as draft November 2, 2024 14:06
@jonasdeluna jonasdeluna changed the title Update achievement styling from flex to grid Update achievement styling to be better Nov 2, 2024
@jonasdeluna jonasdeluna closed this Nov 2, 2024
@jonasdeluna jonasdeluna reopened this Nov 2, 2024
@jonasdeluna jonasdeluna force-pushed the feat-update-achievement-styling branch from 37f2698 to 8d4bd21 Compare November 2, 2024 20:45
@jonasdeluna jonasdeluna marked this pull request as ready for review November 2, 2024 20:45
@jonasdeluna jonasdeluna self-assigned this Nov 2, 2024
@jonasdeluna jonasdeluna requested a review from a team November 2, 2024 20:46
@jonasdeluna jonasdeluna added bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Nov 2, 2024
Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@jonasdeluna jonasdeluna merged commit f195244 into master Nov 3, 2024
6 checks passed
@jonasdeluna jonasdeluna deleted the feat-update-achievement-styling branch November 3, 2024 14:37
@jonasdeluna jonasdeluna removed the review-needed Pull requests that need review label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants