You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps lego-editor in order to remove width: 140px from globals.css. This also caused all buttons not using the lego-bricks<Button> to have default button styling. To handle this, global button css has been added.
Changes look good on both light and dark theme.
Changes look good with different viewports (mobile, tablet, etc.).
Changes look good with slower Internet connections.
I'm not a fan of f680726. These buttons use the button tag for a reason, and they don't look good as a Button. In e.g. the dropdown it looks better to fill the background like for the other items. I vote to revert this commit.
I'm not a fan of f680726. These buttons use the button tag for a reason, and they don't look good as a Button. In e.g. the dropdown it looks better to fill the background like for the other items. I vote to revert this commit.
Hmm, imo it looks slightly more consistent compared to the rest of the website, but I don't have a strong opinion on it. Refactoring all buttons is definitely out of scope for this PR anyways. Will revet it and add some global styling
Hmm, imo it looks slightly more consistent compared to the rest of the website, but I don't have a strong opinion on it. Refactoring all buttons is definitely out of scope for this PR anyways. Will revet it and add some global styling
In some special cases it makes sense to just use a button, like on the unauthenticated login component. I also think it looks better to "fill" the entire dropdown item background. I agree that it's good to be consistent though, but that's what we have the Button component for.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
lego-editorin order to removewidth: 140pxfromglobals.css. This also caused all buttons not using thelego-bricks<Button>to have default button styling. To handle this, global button css has been added.Testing
Verify that all tables look and behave correctly.