Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support anonymized survey submissions #4988

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Support anonymized survey submissions #4988

merged 1 commit into from
Sep 24, 2024

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Sep 24, 2024

Description

Currently we send the user object with every survey submission, which is not ideal because we tell users they are anonymous. This makes changes to frontend to support the changes to the API endpoint removing the user field from the submissions.

Backend PR: webkom/lego#3529

Result

No visual or functional changes.

Testing

  • I have thoroughly tested my changes.

Resolves ABA-273

Copy link

linear bot commented Sep 24, 2024

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Sep 24, 2024 0:08am

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!🤩

@eikhr eikhr merged commit d05da0a into master Sep 24, 2024
6 checks passed
@eikhr eikhr deleted the anonymize-surveys branch September 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants