Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button styling in bricks #4975

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix button styling in bricks #4975

merged 3 commits into from
Sep 23, 2024

Conversation

Bestem0r
Copy link
Contributor

Description

The latest version of lego-bricks incorrectly styles buttons, adding a gray background and border. This is likely caused by the recent removal of the global css import from lego-webapp. This PR fixes the styling.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After
Screenshot from 2024-09-22 17-17-49 Screenshot from 2024-09-22 17-17-58
Screenshot from 2024-09-22 17-27-25 Screenshot from 2024-09-22 17-27-33

Testing

  • I have thoroughly tested my changes.

Navigate through the application and ensure all buttons, icon buttons and link buttons have the correct styling.

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 4:14pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Sep 22, 2024
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, but I'm not sure about the fix. I don't really like global styling. Can't this be fixed in the button specific css file?

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ivarnakken
Copy link
Member

Remember to squash commits

@Bestem0r Bestem0r merged commit 1069232 into master Sep 23, 2024
6 checks passed
@Bestem0r Bestem0r deleted the fix-button-styling branch September 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants