Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct registrationDeadline in event editor #4964

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

norbye
Copy link
Member

@norbye norbye commented Sep 16, 2024

Description

The little text in the editor was using a variable that was not set - and therefore always showed the current time.

Now it uses the same function as is used when it is displayed, and works better.

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
image

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ... (either GitHub issue or Linear task)

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Sep 16, 2024 11:20am

@github-actions github-actions bot added the review-needed Pull requests that need review label Sep 16, 2024
@norbye norbye added the flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! label Sep 16, 2024
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@norbye norbye merged commit 377395b into master Sep 16, 2024
6 checks passed
@norbye norbye deleted the unregisterDeadline-bug branch September 16, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants