Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set input font size to be 16px on mobile #4959

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Sep 13, 2024

Description

For some dumb reason, any inputs with a smaller font size than 16px will cause the browser on mobile (I think only Safari) to "zoom" in on the field when focusing on it. On the event registration modal, this causes annoying bugs when trying to search for attendees.

Read more here.

Testing

  • I have thoroughly tested my changes.

Not actually tested, other than that I have confirmed that the font-size is 16px on mobile viewports.


Resolves ABA-1068

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Sep 13, 2024
@ivarnakken ivarnakken requested review from eikhr and a team September 13, 2024 20:21
@ivarnakken ivarnakken self-assigned this Sep 13, 2024
Copy link

linear bot commented Sep 13, 2024

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 2:50pm

@ivarnakken ivarnakken force-pushed the font-size-input-on-mobile branch 10 times, most recently from d313194 to b59e15f Compare September 14, 2024 14:00
For some dumb reason, any inputs with a smaller font size than `16px`
will cause the browser on mobile (I think only Safari) to "zoom" in on
the field. On the event registration modal, this causes annoying bugs
when trying to search for attendees.
@ivarnakken ivarnakken added the approved Pull requests that have been approved label Sep 14, 2024
@ivarnakken ivarnakken force-pushed the font-size-input-on-mobile branch 5 times, most recently from 5991fdf to 4a6f491 Compare September 14, 2024 18:10
@ivarnakken ivarnakken merged commit c7d3c38 into master Sep 14, 2024
8 checks passed
@ivarnakken ivarnakken deleted the font-size-input-on-mobile branch September 14, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants