Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mazemap from 2.0.63 to 2.0.96 #4170

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Bump mazemap from 2.0.63 to 2.0.96 #4170

merged 4 commits into from
Oct 11, 2023

Conversation

ollfkaih
Copy link
Contributor

@ollfkaih ollfkaih commented Oct 5, 2023

Description

Bumps mazemap from 2.0.63 to 2.0.96

Release notes

Sourced from mazemaps api docs.

version 2.0.96

May 5, 2023

Update a console error to include missing error information

version 2.0.95

March 21, 2023

Minor change in the [JSAPI as NPM Module + React](https://api.mazemap.com/js/v2.0.106/docs/#ex-jsapi-module-import-react-project) example.

version 2.0.94

February 28, 2023

Fixed bug where icon images could sometimes have wrong offset.

version 2.0.93

January 25, 2023

Make the Mazemap.Config.getSearchApiBaseUrl() include /search by default. Should not affect any existing integrations unless you are manually setting the search api base url using Mazemap.Config.setSearchApiBaseUrl()
Switch from devtiles.mazemap.com to staging-tiles.mazemap.com as tile server for the staging environment.
Added a basic venue/conference app integration solution example
Enable Ambient Occlusion shadow rendering by default in 3d mode.

version 2.0.92

January 20, 2023

Upgrade Mapbox GL version from 2.8.2 to 2.12.0. https://github.com/mapbox/mapbox-gl-js/releases

version 2.0.91

December 21, 2022

Fixed a bug where the floorId returned by the Mazemap.Util.getMapClickData function would point to the outline id instead of floor id.

version 2.0.90

December 15, 2022

Turned on options.antialias by default on the map object for increasing visual quality of lines and 3d objects.

version 2.0.89

December 14, 2022

Fixed a bug in the map zLevelUpdater when using buildingClosestToCenter option. It would sometimes set an empty object of zLevels instead of refreshing properly.

version 2.0.88

December 13, 2022

Added imgOffsetLeft and imgOffsetTop options to MazeMarker.

version 2.0.87

December 12, 2022

Fixed CORS issue with routing arrow png image.
Updated [BlueDot](https://api.mazemap.com/js/v2.0.106/docs/#api-bluedot) documentation, describing how the zLevel can be set to null for outdoor/unknown floor, and adding examples of how this is visualized in the map.
Added documentation in API Reference: [BlueDot](https://api.mazemap.com/js/v2.0.106/docs/#api-bluedot)
See [Basic BlueDot](https://api.mazemap.com/js/v2.0.106/docs/#ex-bluedot-basic) example and [BlueDot Location Controller](https://api.mazemap.com/js/v2.0.106/docs/#ex-bluedot-location-controller) example.

version 2.0.86

December 6, 2022

Added support for [Basic 3D Maps](https://api.mazemap.com/js/v2.0.106/docs/#ex-basic-3d). See example page.

version 2.0.85

December 5, 2022

Fixed bug: There was a minor visual bug in the [BlueDot](https://api.mazemap.com/js/v2.0.106/docs/#ex-bluedot-basic) direction/bearing indication, where it could sometimes overshoot the animation and look weird.

version 2.0.84

November 30, 2022

Added experimental zLevelUpdaterType: 'userFocused' floor level handler, available as new [Map options](https://api.mazemap.com/js/v2.0.106/docs/#api-map).

version 2.0.83

November 18, 2022

Minor adjustments to api reference documentation

version 2.0.82

November 17, 2022

Added support for directional arrows on routes. See option showDirectionArrows on the [RouteController](https://api.mazemap.com/js/v2.0.106/docs/#api-routecontroller) class. This is off by default and can be turned on by setting the option to true. See the [Basic Route](https://api.mazemap.com/js/v2.0.106/docs/#ex-route-basic) for a visual example of how this looks.
Added support for different route colors for DRIVE and BICYCLE segments. These colors are customizable in the [RouteController](https://api.mazemap.com/js/v2.0.106/docs/#api-routecontroller) class.

version 2.0.80

October 31, 2022

Added an optional visual component to the [BlueDot](https://api.mazemap.com/js/v2.0.106/docs/#ex-bluedot-basic) class to indicate direction/bearing.

version 2.0.75

August 26, 2022

Minor changes to the position of map attribution control and size of MazeMap logo.

version 2.0.74

June 22, 2022

Added externalId to campus data model.

version 2.0.72

May 23, 2022

Changed the default outdoor base map style to "v2022", with more visible car parks and green areas.

version 2.0.70

March 31, 2022

Added [Show POI Information](https://api.mazemap.com/js/v2.0.106/docs/#ex-rich-poi) example to demonstrate how to show Rich Poi info, such as images.

version 2.0.66

Februrary 25, 2022

Breaking change:
Removed legacy Mazemap.Data.getPoiCategoryStyleById method.
Breaking change:
Renamed Mazemap.Data.getPoiCategoryIdsByCampusId to getSelectablePoiTypesForCampusId.
Breaking change:
Renamed Mazemap.Data.getPoisByCategoryAndCampusId to getPoisByTypeIdAndCampusIdAsGeoJSON.
Updated [Fetching POI Types](https://api.mazemap.com/js/v2.0.106/docs/#ex-data-poi-types) example to use newly named methods and using new poi type icon url.

version 2.0.65

Februrary 24, 2022

Added[ guidelines page](https://api.mazemap.com/js/v2.0.106/docs/#guidelines)
Added getIconSvgUrl and getIconPngUrl. See [Data: Icons](https://api.mazemap.com/js/v2.0.106/docs/#api-data:-icons), and [Fetching Poi Type Example](https://api.mazemap.com/js/v2.0.106/docs/#ex-data-poi-types).

version 2.0.64

Februrary 9, 2022

Improve theming of the floor selector control, adding a new activeColor option + setActiveColor(color) method.
This makes it easier to programmatically set the color of the floor selector, without needing to specify CSS overrides in a stylesheet.

Result

Seemingly everything works like before but it should now use a newer mapbox version.
(Newest version doesnt work with our webpack config)

Testing

  • I have thoroughly tested my changes.
    Map and search still works

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 5, 2023
@ivarnakken ivarnakken added dependencies Pull requests that update a dependency file approved Pull requests that have been approved labels Oct 5, 2023
@ollfkaih ollfkaih added do-not-merge/WIP Pull requests that are "work in progress", and should not be merged flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! and removed do-not-merge/WIP Pull requests that are "work in progress", and should not be merged labels Oct 5, 2023
ivarnakken
ivarnakken reviewed Oct 6, 2023
View reviewed changes
app/components/Search/mazemapAutocomplete.tsx Outdated
@@ -87,6 +87,7 @@ function mazemapAutocomplete<Props>({
),
});
})
.catch((error) => {})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this? You don't do anything with the error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but something seems to have changed about the search in mazemap so it will throw something like "search cancelled because a new one was initiated" when writing (because that triggers new searches)

app/components/MazemapEmbed/index.tsx
@@ -176,6 +184,7 @@ export const MazemapEmbed = ({ mazemapPoi, ...props }: Props) => {
touchAction: 'pan-x pan-y',
}}
id="mazemap-embed"
className={styles.mazemapEmbed}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this styling is affecting? The span below? Because that has already a color: #111 by the blockingText class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the color of the other text in the embed also black, even on dark mode. Previously zLevelControl (floor selector) got white text on white bg on dark mode.

@ollfkaih ollfkaih force-pushed the ollfkaih/bump-mazemap branch 3 times, most recently from 1120eea to 4313794 Compare October 6, 2023 16:32
@ollfkaih ollfkaih removed the review-needed Pull requests that need review label Oct 11, 2023
@ollfkaih ollfkaih merged commit 2e645a0 into master Oct 11, 2023
4 checks passed
@ollfkaih ollfkaih deleted the ollfkaih/bump-mazemap branch October 11, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

@norbye norbye norbye approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved dependencies Pull requests that update a dependency file flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ollfkaih @norbye @ivarnakken