-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme toggle button bugs #3875
Conversation
… menu, add debounce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your contribution! ⭐
Just move the eventListener
to the useEffect
and I'm happy to merge this in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
The CI is just failing on lint
(you're missing a newline in the css 🙃) so when CI passes this can go in 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just come by the webkom-office in F252 if you want a LEGO-pin:) There is almost always someone there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 🚀🚀
Looks nice, but I have a small nitpick 😅
Co-authored-by: Ivar Nakken <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!💯
@Bestem0r Another slight issue here 😅. We had a small issue with the CI that was fixed a few days ago, so you need to rebase this on master for CI to work properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Remember to squash before you merge!
… menu, add debounce
…ebjorn/fix/theme-toggle # Conflicts: # app/components/Header/Header.css
Description
Result
Testing
Resolves: #2926