Remove adminComment/note field from companies

webkom · Sep 25, 2024 · b8d9658 · b8d9658
1 parent 932b29f
commit b8d9658
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 32 deletions.
diff --git a/app/routes/bdb/components/BdbDetail.tsx b/app/routes/bdb/components/BdbDetail.tsx
@@ -458,11 +458,6 @@ const BdbDetail = () => {
           </ul>
         </div>
 
-        <div className={styles.adminNote}>
-          <h3>Notat i listen</h3>
-          {company.adminComment || <EmptyState body="Ingen notater" />}
-        </div>
-
         <div>
           <h3>Bedriftens arrangementer</h3>
           {events.length > 0 ? (

diff --git a/app/routes/bdb/components/BdbPage.tsx b/app/routes/bdb/components/BdbPage.tsx
@@ -222,15 +222,12 @@ const BdbPage = () => {
       },
     },
     {
-      title: 'Notat',
-      dataIndex: 'comment',
+      // Using an empty column for filtering
+      title: '',
+      dataIndex: 'Filter',
       centered: false,
-      maxWidth: 200,
-      render: (_, company) => company.adminComment,
-      sorter: (a, b) =>
-        a.adminComment?.localeCompare(b.adminComment || '') || 0,
-
-      // Using the last column for this filtering, even though it's unrelated
+      maxWidth: 50,
+      render: (_, ) => '',
       filterIndex: 'active',
       filter: [
         { value: 'true', label: 'Aktiv' },

diff --git a/app/routes/bdb/components/CompanyEditor.tsx b/app/routes/bdb/components/CompanyEditor.tsx
@@ -113,7 +113,6 @@ const CompanyEditor = () => {
     ? {
         name: '',
         description: '',
-        adminComment: '',
         website: '',
         studentContact: undefined,
         active: 'true',
@@ -125,7 +124,6 @@ const CompanyEditor = () => {
     : {
         name: company.name,
         description: company.description,
-        adminComment: company.adminComment,
         website: company.website,
         studentContact: studentContact && {
           id: studentContact.id,
@@ -306,15 +304,7 @@ const CompanyEditor = () => {
                 />
               </MultiSelectGroup>
             </div>
-
-            <Field
-              placeholder="Bedriften ønsker kun kurs"
-              label="Notat fra Bedkom"
-              name="adminComment"
-              component={TextEditor.Field}
-              className={styles.adminNote}
-            />
-
+
             <SubmissionError />
             <SubmitButton>{isNew ? 'Opprett' : 'Lagre'}</SubmitButton>
           </form>

diff --git a/app/routes/bdb/components/__tests__/fixtures/companies.ts b/app/routes/bdb/components/__tests__/fixtures/companies.ts
@@ -11,7 +11,6 @@ const companies = [
       },
     ],
     studentContact: 'Marius Kotlarz',
-    adminComment: 'Husk logo på alle sider',
   },
   {
     name: 'Facebook',

diff --git a/app/routes/bdb/components/bdb.css b/app/routes/bdb/components/bdb.css
@@ -177,10 +177,6 @@
   }
 }
 
-.adminNote {
-  width: 400px;
-}
-
 .editTitle {
   width: 250px;
 }

diff --git a/app/store/models/Company.ts b/app/store/models/Company.ts
@@ -80,7 +80,6 @@ interface Company {
   thumbnail?: string;
   semesterStatuses?: SemesterStatus[];
   studentContact?: EntityId | null;
-  adminComment?: string;
   paymentMail: string;
   comments: EntityId[];
   contentTarget: ContentTarget;
@@ -110,7 +109,6 @@ export type AdminListCompany = Pick<
   | 'name'
   | 'semesterStatuses'
   | 'studentContact'
-  | 'adminComment'
   | 'active'
 >;
 
@@ -155,7 +153,6 @@ export type AdminDetailCompany = Pick<
   | 'contentTarget'
   | 'semesterStatuses'
   | 'active'
-  | 'adminComment'
   | 'logo'
   | 'files'
   | 'companyContacts'