Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Reply-To header to original recipients #1040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

norbye
Copy link
Member

@norbye norbye commented May 29, 2024

The email sent from the system is normally used as a thread. Currently you have to either select the emails manually or hit reply all and remove the sender email.

Has been tested and works the way I expected it to(:

The email sent from the system is normally used as a thread. Currently you have to either select the emails manually or hit reply all and remove the sender email.
@norbye norbye added the review-needed Pull requests that need review label May 29, 2024
@norbye norbye marked this pull request as ready for review May 30, 2024 05:40
@norbye norbye added the enhancement New feature or request label May 30, 2024
@norbye norbye requested a review from a team May 30, 2024 05:42
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the expected behaiviour here would be that it replies to the sender of the receipt? I feel like it could be confusing if it doesn't follow normal email convention

But I don't use the system myself, so I don't really know what the typical use cases are.

@eikhr eikhr requested a review from a team May 30, 2024 06:08
@norbye
Copy link
Member Author

norbye commented May 30, 2024

Wouldn't the expected behaiviour here would be that it replies to the sender of the receipt? I feel like it could be confusing if it doesn't follow normal email convention

But I don't use the system myself, so I don't really know what the typical use cases are.

The reason I added both the sender and the receiver is sortof twofold

  • The same email is sent to both - so if you set reply-to to be only the sender of the receipt, then the sender would reply to itself if it pressed the reply-button
  • The recipient is normally an email-list, and as such it's neat for the rest of the list to continue to be in the thread if there is any discussion (although the list normally only has one recipient, it is normal to be two recipients for a few months when transitioning from one to another)

You're probably right though - so I'll see if there are any better ways of solving this. Did some more testing and it turns out when you reply to yourself without an email-list it will pop up as unread in your inbox even if you're the sender - which is kinda annoying..

@eikhr
Copy link
Member

eikhr commented May 30, 2024

Wouldn't the expected behaiviour here would be that it replies to the sender of the receipt? I feel like it could be confusing if it doesn't follow normal email convention
But I don't use the system myself, so I don't really know what the typical use cases are.

The reason I added both the sender and the receiver is sortof twofold

  • The same email is sent to both - so if you set reply-to to be only the sender of the receipt, then the sender would reply to itself if it pressed the reply-button
  • The recipient is normally an email-list, and as such it's neat for the rest of the list to continue to be in the thread if there is any discussion (although the list normally only has one recipient, it is normal to be two recipients for a few months when transitioning from one to another)

You're probably right though - so I'll see if there are any better ways of solving this. Did some more testing and it turns out when you reply to yourself without an email-list it will pop up as unread in your inbox even if you're the sender - which is kinda annoying..

Hmm, I guess it's kind of unintuitive either way when the same email is sent to the sender and recipients. But I feel like for recipients discussing the email they should be using reply-all and just remove the sender, as this is what you would do for any other incoming email.
In any case I think the most important thing is that it doesn't work in some unexpected way that leads to people not receiving emails they should get, so rather include too many recipients than too few imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants