Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag allowing interop view to be viewed everywhere #3001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gsnedders
Copy link
Member

Description

This adds a flag which overrides the default logic for allowing the interop scores.

Review Information

As I understand it, we pull defaults from somewhere server-side; it's not clear to me where actually controls this. As I understand, it sounds like
people with admin accounts on wpt.fyi can change these defaults, but given they default to false this shouldn't need anything to be done there.

Note I haven't actually tested this (I don't have a working local setup), so someone who does should probably test this as part of the review.

@KyleJu
Copy link
Collaborator

KyleJu commented Oct 14, 2022

The deployment failed because this PR is from a fork. I am happy to deploy one manually after the review

@DanielRyanSmith
Copy link
Contributor

@jgraham Do you have opinions on this?

@jgraham
Copy link
Contributor

jgraham commented Oct 14, 2022

Yes, I continue to believe this is a bad idea. The Interop-202x tests are special in that we've got mutual agreement that they make sense to score in this way. We don't have that agreement for arbitary tests, so I don't think we should add an override like this.

@gsnedders
Copy link
Member Author

Yes, I continue to believe this is a bad idea. The Interop-202x tests are special in that we've got mutual agreement that they make sense to score in this way. We don't have that agreement for arbitary tests, so I don't think we should add an override like this.

IMO, flags are sufficiently niche that this risk is very low, for the same reason as why having colours on the homepage behind a flag isn't harmful.

@gsnedders
Copy link
Member Author

gsnedders commented Oct 15, 2022

Also, like, to be explicit, the current logic is very naïve and easy to work around: searching for (label:interop-2022-color or not label:interop-2022-color) will let you get interop view anywhere as is, and that's arguably more obvious than the /flags page nobody knows exists.

And as justification: being able to actually see how browsers do (under the current scoring) on things proposed for Interop 2023 is valuable during the review time period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants