Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ES Modules #147

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Move to ES Modules #147

wants to merge 4 commits into from

Conversation

reesericci
Copy link

Adds support for use as an ESM module with the following syntax:

import Filter from 'badwords'

@reesericci reesericci mentioned this pull request Apr 29, 2022
Copy link
Owner

@web-mech web-mech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to support ESM here without needing to support both ESM + CJS. But this will need to be a part of a major release. We should also update the dependencies being required here.

@web-mech web-mech changed the base branch from master to next January 5, 2023 14:49
@TamimiGitHub
Copy link

Any update on this?

@reesericci
Copy link
Author

As far as I know, this branch is working and I'm not sure what the timeline is on being merged. I'll go through and make the dependencies use ESM import though to resolve the changes requested by @web-mech .

@reesericci
Copy link
Author

Just moved everything over to ESM in this PR!

@reesericci reesericci changed the title Support ESM Move to ES Modules Aug 8, 2024
@TamimiGitHub
Copy link

Fantastic, thanks for that @reesericci! I'll keep an eye out on the next release

@web-mech
Copy link
Owner

Thanks @reesericci , will see if we can merge this in soon

web-mech added a commit that referenced this pull request Aug 14, 2024
moves all source files to src folder. also types for everything. better documented everything as
well

#166, #147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants