Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm UNASSOCIATED_MODULE_INSTANCE_REFS #8327

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Nov 4, 2024

Summary

Pass compilation id in build_module, succeed_module hooks. And remove UNASSOCIATED_MODULE_INSTANCE_REFS for JsModuleWrapper.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2e0c4c5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672adfc474cffd0008ad630b

@SyMind SyMind marked this pull request as ready for review November 5, 2024 08:58
@SyMind SyMind changed the title chore: rm UNASSOCIATED_MODULE_INSTANCE_REFS refactor: rm UNASSOCIATED_MODULE_INSTANCE_REFS Nov 5, 2024
jerrykingxyz
jerrykingxyz previously approved these changes Nov 5, 2024
@SyMind
Copy link
Member Author

SyMind commented Nov 6, 2024

!eco-ci

@SyMind
Copy link
Member Author

SyMind commented Nov 6, 2024

!bench

@web-infra-dev web-infra-dev deleted a comment from rspack-bot Nov 6, 2024
@rspack-bot
Copy link

rspack-bot commented Nov 6, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ❌ failure
devserver ✅ success

@rspack-bot
Copy link

rspack-bot commented Nov 6, 2024

📝 Benchmark detail: Open

Name Base (2024-11-06 666d40a) Current Change
10000_big_production-mode + exec 43.6 s ± 959 ms 43.4 s ± 923 ms -0.51 %
10000_development-mode + exec 1.84 s ± 13 ms 1.85 s ± 18 ms +0.45 %
10000_development-mode_hmr + exec 644 ms ± 7.8 ms 645 ms ± 5.7 ms +0.06 %
10000_production-mode + exec 2.41 s ± 30 ms 2.43 s ± 32 ms +0.83 %
arco-pro_development-mode + exec 1.78 s ± 78 ms 1.74 s ± 65 ms -2.25 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.9 ms 431 ms ± 3.1 ms +0.19 %
arco-pro_production-mode + exec 3.17 s ± 65 ms 3.19 s ± 99 ms +0.79 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.26 s ± 80 ms 3.28 s ± 99 ms +0.47 %
threejs_development-mode_10x + exec 1.59 s ± 16 ms 1.58 s ± 21 ms -0.32 %
threejs_development-mode_10x_hmr + exec 775 ms ± 19 ms 773 ms ± 9.3 ms -0.29 %
threejs_production-mode_10x + exec 4.95 s ± 36 ms 4.96 s ± 26 ms +0.14 %

@SyMind SyMind merged commit ab3cdfb into main Nov 6, 2024
29 checks passed
@SyMind SyMind deleted the module-with-compilation-id branch November 6, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants