Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid argument error in stdin mode #341

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Fix invalid argument error in stdin mode #341

merged 5 commits into from
Sep 3, 2024

Commits on Sep 2, 2024

  1. Send meaningful json and exit directly if invalid argument is encount… 

    …ered in stdin mode
    @mrts
    Lauris Kaplinski authored and mrts committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    89c5f1b View commit details
    Browse the repository at this point in the history

  2. Use QString::fill instead of eraseData to force copy-on-write

    @mrts
    Lauris Kaplinski authored and mrts committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1f3cdb0 View commit details
    Browse the repository at this point in the history

  3. Update src/controller/controller.cpp 

    Co-authored-by: Raul Metsma <[email protected]>
    @lauris71 @metsma @mrts
    2 people authored and mrts committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6e9b434 View commit details
    Browse the repository at this point in the history

  4. Revert unnecessary std::invalid_argument handling 

    WE2-479

Signed-off-by: Mart Somermaa <[email protected]>
    @mrts
    mrts committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f67d758 View commit details
    Browse the repository at this point in the history

  5. Remove code duplication by implementing displayPinBlockedError() via … 

    …displayFatalError()

WE2-479

Signed-off-by: Mart Somermaa <[email protected]>
    @mrts
    mrts committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a5825d0 View commit details
    Browse the repository at this point in the history