Fixed some TODOs #304
Merged
Fixed some TODOs #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 30, 2023 13:53
Squashed commits: [d850e68] Revert "Reorganized pin handling to be extra sure that copy remains in memory" This reverts commit fdc8b43. [99bc2b5] Revert "Clear pin string from dialog after query" This reverts commit 2ea88b0. [b07c28d] Revert "Clear PIN ui with setText("") if certificate is changed" This reverts commit a6763ea. [a6763ea] Clear PIN ui with setText("") if certificate is changed [d743b24] Separated invalid input error from other technical erros [2ea88b0] Clear pin string from dialog after query [fdc8b43] Reorganized pin handling to be extra sure that copy remains in memory [02662c1] Do not allow PIN retry on unknown error, instead show "technical error" and cancel button Output {"invalid-argument":"message"} in stdin/out mode if json parsing fails
mrts
requested changes
May 14, 2024
Co-authored-by: Mart Sõmermaa <[email protected]>
Co-authored-by: Mart Sõmermaa <[email protected]>
mrts
force-pushed
the
WE-145-squash
branch
2 times, most recently
from
63627a0
to
075bfaf
Compare
WE2-145 Signed-off-by: Mart Somermaa <[email protected]>
mrts
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WE2-145
FixedTODOs that do not need major code refactoring
Signed-off-by: Lauris Kaplinski [email protected]