Fix coverity errors

WE2-1003 Signed-off-by: Raul Metsma <[email protected]>
web-eid · Aug 7, 2024 · a057c90 · a057c90
1 parent e42c67e
commit a057c90
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/lib/libelectronic-id b/lib/libelectronic-id
diff --git a/src/ui/webeiddialog.cpp b/src/ui/webeiddialog.cpp
@@ -340,13 +340,12 @@ void WebEidDialog::onMultipleCertificatesReady(
     case CommandType::AUTHENTICATE:
         ui->selectAnotherCertificate->disconnect();
         ui->selectAnotherCertificate->setVisible(certificateAndPinInfos.size() > 1);
-        connect(ui->selectAnotherCertificate, &QPushButton::clicked, this,
-                [this, origin, certificateAndPinInfos] {
-                    // We set pinInput to empty text instead of clear() to also reset undo buffer
-                    ui->pinInput->setText({});
-                    onMultipleCertificatesReady(origin, certificateAndPinInfos);
-                });
-        setupOK([this, origin] {
+        connect(ui->selectAnotherCertificate, &QPushButton::clicked, this, [=] {
+            // We set pinInput to empty text instead of clear() to also reset undo buffer
+            ui->pinInput->setText({});
+            onMultipleCertificatesReady(origin, certificateAndPinInfos);
+        });
+        setupOK([=] {
             ui->okButton->setDisabled(true);
             // Authenticate continues with the selected certificate to onSingleCertificateReady().
             if (auto* button =
@@ -382,7 +381,7 @@ void WebEidDialog::onSingleCertificateReady(const QUrl& origin,
     switch (currentCommand) {
     case CommandType::GET_SIGNING_CERTIFICATE:
         setupCertificateAndPinInfo({certAndPin});
-        setupOK([this, certAndPin] {
+        setupOK([=] {
             ui->okButton->setDisabled(true);
             emit accepted(certAndPin);
         });
@@ -556,7 +555,7 @@ void WebEidDialog::setTrText(QWidget* label, Text text) const
 void WebEidDialog::connectOkToCachePinAndEmitSelectedCertificate(
     const CardCertificateAndPinInfo& certAndPin)
 {
-    setupOK([this, certAndPin] {
+    setupOK([=] {
         ui->pinInput->hide();
         ui->pinTitleLabel->hide();
         ui->pinErrorLabel->hide();