Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make promotions work "usually once" and move the handling of them to the controller #197

Open
2 tasks
squaremo opened this issue Sep 21, 2023 · 0 comments
Open
2 tasks

Comments

@squaremo
Copy link
Contributor

squaremo commented Sep 21, 2023

Once the promotion algorithm is implemented #195, we can fill in the promotion handlers by adapting the code currently used by the webhook server. The controller should record the fact of each promotion in the pipeline status so that it

  • does retry a promotion that failed; and,

  • doesn't retry a promotion that succeeded.

  • the webhook receivers should still work, but succeed trivially (i.e., no-op and return 200), so demos don't break immediately

  • test that promotions are triggered reliably; it's not a goal to prove that automated PRs work as expected, only that this code handles success and failures

  • not a goal to make promotion handling run asynchronously. In the reconcile loop is OK for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants