-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pipelines UI] Add Icon that shows promotion progress #3431
Comments
@joshri Do we need to discuss? |
We need to determine the criteria for the different stages of progress for promotion so I can know what to look for |
Hi @mmoulian and @joshri: These buttons should operate as either/or, yes/no, succeeded/not-succeeded-yet, instead of as markers tracking progress. So the behavior for now should be that the button remains light green until the promotion has succeeded, then switches dark green to indicate that the promotion has succeeded. Does that help? |
If needed, I can prototype this behavior in Figma |
Please do @mmoulian |
@LappleApple and @joshri This is an initial prototype showing the behavior of the buttons and icon, maybe a little naive. It should be reviewed with someone with technical knowledge... Actions: -The user clicks the button to Approve promotion in the STG column -While the promotion is completed, we show a progress indicator (flashing circle animation) Pipeline.behavior.mov |
@mmoulian Heya, thanks for working on this. However, it should behave exactly as I wrote earlier. The button should either be light green (promotion not successful yet) or green (promotion is successful). |
@LappleApple Sorry, I'm a little confused about it. I understand that in design we have two areas of interaction.
Then in the feedback area: Does it happen in the first development column? What happens in the Stg column? |
Hi @mmoulian and @joshri: spent some time this afternoon digging into this one. Here's the Miro mockup with requested changes:
As the mockup shows, behavior in the middle area between envs gets a bit busier now. We want to enable a few different prompts around the green promotion button, based on whether there's manual or automated approvals or whether there's a PR or notification strategy. I can explain in person if necessary. |
@LappleApple and @joshri. I did a couple of prototype tests trying to follow Laurie's notes.
AUTOMATED.WITH.PROGRESS.INDICATOR.movAUTOMATED.PR.mov |
@mmoulian I like the first one because it suggests "things are happening right now" |
@LappleApple @joshri I made an example of manual approval behavior... pipeline.behavior.-.manual.approvals.mov |
In the event that we have an error in the PR... the message disappears after a few seconds and the user can start again... wdyt? Pipeline.behavior-.manual.fail.mov |
@mmoulian Button progress is on the right track. :) Next for the manual approval option, we'll want (repeating what's in the Miro, but moving over here):
|
@LappleApple Please, check these movies: -Manual approval: The PR is created (shows the link) Manual.Approval.-.Created.movManual.Approval.-.Fail.movManual.Approval.-.Retrying.mov |
@mmoulian Thanks much -- all good except one nit. We need the hyphen in the prompt, so that it says: If that messes up the design, then this could work: |
Fixed it Manual.Approval.UNSUCCESSFUL-.TO.RETRY.v2.mov |
Blocked by weaveworks/pipeline-controller#197 |
Followup to #3428
The text was updated successfully, but these errors were encountered: