Avoid crash on degenerate test case

weaveworks-experiments · May 6, 2021 · 87e8afc · 87e8afc
1 parent 4228c28
commit 87e8afc
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/controllers/events/mocks_for_test.go b/controllers/events/mocks_for_test.go
@@ -137,6 +137,9 @@ func (f *fakeExporter) sort() {
 			topSpan = i
 		}
 	}
+	if topSpan == -1 { // no top span found; can't do DFS
+		return
+	}
 
 	sortedSpans := make([]*tracesdk.SpanSnapshot, 0, len(f.SpanSnapshot))
 	t := dfs{