Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added invoice receipts #12

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

added invoice receipts #12

wants to merge 14 commits into from

Conversation

psousa
Copy link
Contributor

@psousa psousa commented May 8, 2015

No description provided.

@paulosilva86
Copy link
Contributor

🆗 Still missing tests for InvoiceReceipts though right?

@psousa
Copy link
Contributor Author

psousa commented May 11, 2015

Yes, didn't have time for those. Probably by the end of the week.

@paulosilva86
Copy link
Contributor

Ok. No problem. Good job. You can merge whenever you want.

@vascosantos
Copy link

Hi! Any chance of completing this merge anytime soon?

@igorescobar
Copy link
Contributor

Any chance of completing this merge anytime soon?

@igorescobar
Copy link
Contributor

@donbonifacio would be great to merge this. this is actually missing in the implementation.

@igorescobar
Copy link
Contributor

@igorescobar
Copy link
Contributor

@psousa can you take a look into this conflicts?

@vascosantos
Copy link

@igorescobar I cloned this repo onto my own account and implemented the invoice receipts part (which is the part I was missing for my project). I did not include any tests.
Seems to be working fine so far.
Feel free to use from: https://github.com/vascosantos/invoicexpress-gem

@igorescobar
Copy link
Contributor

@vascosantos cool but @paulosilva86 gave the green light to merge this and somehow It wasn't...

@vascosantos
Copy link

@igorescobar, I saw that as well, but the merge has been pending for more than 1 year. So I looked at the diffs in the code and copy&pasted on the repository I sent you.

@igorescobar
Copy link
Contributor

👓

@psousa
Copy link
Contributor Author

psousa commented Apr 5, 2018

I didn't receive notifications from these comments.

So 3 things:

  • I've added tons of missing features/endpoints which were missing from the API and I needed over the last year. Things like transport guides or using logo in email.
  • I've bumped the version (sorry, sorry, sorry, I know I should't have done).
  • It doesn't have new specs for everything. I won't have time to add them.

I hope further pull requests will be done in a faster, more orderly way.

I'll paste below the changes I've made:

Version 0.3.2

Added current_invoice_receipt_number and current_invoice_receipt_sequence_id to sequences.

Version 0.3.1.1

Merged changes from other contributors. Bumped version.

Version 0.3.0

More big changes on this version:

  • added logo option to send email
  • added transport guides client
  • set params_encoder = Faraday::FlatParamsEncoder in GET requests. We need this for the way that IX accepts arrays in GET requests. See Set array parameters from a Ruby array lostisland/faraday#78
  • fixed missing owner_invoice_id, manual_sequence_number, currency_code, rate params on update credit note and debit note
  • added models for address, message, transport guide
  • added tests for transport guides

Version 0.2.5

Big changes on this version:

  • updated send email endpoint for invoices
  • cleanup gemspec file
  • started cleaning up test files from should to expect
  • added manual_sequence_number field to invoices. Required for non portuguese accounts with manual sequence numbering.
  • added saft_hash field to invoices
  • added currency, multicurrency to invoices. not supported officially.
  • added owner_invoice_id to credit_note. not working.

Version 0.2.0

Support for 429 RateLimitExceeded code
Added Invoice Receipt
Added supplier model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants