Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include SCA policy for Rocky Linux 9 in SPECS #2299

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Include SCA policy for Rocky Linux 9 in SPECS #2299

merged 4 commits into from
Jan 18, 2024

Conversation

DFolchA
Copy link
Contributor

@DFolchA DFolchA commented Jul 19, 2023 •
edited
Loading

Related issue
Closes #2282

Description

This PR adds the necessary modifications to the SPECS to include the new Rocky Linux 9 SCA policy.

Logs example

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@DFolchA DFolchA changed the base branch from master to 4.5.1 July 19, 2023 15:28
@DFolchA DFolchA changed the title Sca rocky linux 9 Include SCA policy for Rocky Linux 9 in SPECS Jul 19, 2023
vikman90
vikman90 previously approved these changes Jul 20, 2023
View reviewed changes
@mjcr99 mjcr99 changed the base branch from 4.5.1 to 4.8.1 January 15, 2024 07:11
@mjcr99 mjcr99 dismissed vikman90’s stale review January 15, 2024 07:11

The base branch was changed.

ncvicchi
ncvicchi previously approved these changes Jan 17, 2024
View reviewed changes
lchico
lchico requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@lchico lchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mjcr99. I left one comment, PTAL.

lchico
lchico previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@lchico lchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one minor comment! Feel free to address this.

jotacarma90
jotacarma90 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jotacarma90 jotacarma90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikman90 vikman90 merged commit 0bc4e69 into 4.8.1 Jan 18, 2024
52 checks passed
@vikman90 vikman90 deleted the SCA-Rocky-Linux-9 branch January 18, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcr99 mjcr99 mjcr99 left review comments

@jotacarma90 jotacarma90 jotacarma90 approved these changes

@ncvicchi ncvicchi ncvicchi left review comments

@lchico lchico lchico left review comments

@vikman90 vikman90 vikman90 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPECS for new SCA Rocky Linux 9
6 participants
@DFolchA @vikman90 @lchico @jotacarma90 @ncvicchi @mjcr99