-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the errors in the dashboard for the AIO installation #2118
Conversation
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
8984166
to
2566efb
Compare
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
UpdateDoing the manual testing of the AIO installation, all systems finished the installation abruptly with the following error:
The problem is that the code was copied from version 4.4, where the request used to get the token is GitHub Actions testThe github action test is failing on an unrelated thing to the changes done. For some reason yet undiscovered, it is looking for version |
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, minor changes
unattended_installer/builder.sh
Outdated
echo -e " -d, --development" | ||
echo -e " Use development repos" | ||
echo -e " -d [staging], --development" | ||
echo -e " Use development repos. By default it uses pre-release. If staging is specified, it will be used" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default it uses pre-release
From a user's point of view, what is pre-release? We should specify that it uses the pre-release package repository to emphasize that they are near-final packages.
If pre-release is also an option to specify, it should be specified in:
-d [pre-release|staging]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted the builder.sh
script is not meant for use outside the developing team. That said, the commentary correction and the option to specify pre-release
as well as staging
with argument --development|-d
have been added in commit 81187fc
…ct help commentary for argument --development Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
Signed-off-by: Miguel Verdaguer Velázquez <[email protected]>
UpdateThe number of retries and the time between retries for both the downloading of the token and the initialization of the dashboard have been increased after a test done for the 4.4 version of this PRs has proven more time was needed. The test is specifically the Amazon Linux 2 test done with less than recommended hardware, which traces are in this commentary |
Description
This PR aims to fix the errors seen in the dashboard installation when an All-in-one installation is done in a system with less capabilities than the recommended ones. This errors have discovered some issues on the error treatment of the installation.
For now, function
passwords_getApiToken
now detects one more possible error and retries the Token downloading some number of times.Testing
Test AIO on machines with minimum requirements(4GB and 2 cores):
🟢 Ubuntu 18
🟢 Ubuntu 20
🟢 Ubuntu 22
🟢 CentOS 7
🟢 CentOS 8
🟢 Amazon Linux 2
🟢 RHEL 7
🟢 RHEL 8
🟢 RHEL 9
Test AIO on machines with limited resources (2GB and 1 cores):
🟢 CentOS 9 Stream
🟢 Ubuntu 22
🟢 Amazon Linux 2
🟢CentOS 7
🟢 CentOS 8
🟢 RHEL 9
🟢 Ubuntu18LTS
🟢 Ubuntu20LTS
Test AIO on machines with limited resources (T2.micro EC2 instances):
🔴 Amazon Linux 2 t2.micro
Jenkins tests: