Skip to content

Commit

Permalink
fix: correct issue with typing ignores
Browse files Browse the repository at this point in the history
last upgrades changed the error categories that need to be excluded
the `Model` typealias
  • Loading branch information
plankthom committed May 28, 2024
1 parent 3bbc2ab commit 5a2fdd6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ test-integration: install
test-integration-coverage-report: install ### generate html coverage report for the integration tests
${PYTEST_CMD} --cov-report html:cov_report/integration --cov=src test/integration

test: format test-unit ### perform all quality checks and tests, except for integration tests
test: format code-qa test-unit ### perform all quality checks and tests, except for integration tests


ci-install:
Expand Down
4 changes: 2 additions & 2 deletions src/waylay/sdk/api/_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ def __model_construct_recursive(cls, obj: Any):
Primitive: TypeAlias = Union[
str, bool, int, float, Decimal, bytes, datetime, date, object, None
]
Model: TypeAlias = TypeAliasType( # type: ignore[valid-type] #(https://github.com/python/mypy/issues/16614)
Model: TypeAlias = TypeAliasType( # type: ignore[misc] #(https://github.com/python/mypy/issues/16614)
"Model",
Annotated[
Union[List["Model"], "_Model", Primitive], # type: ignore[misc,possible cyclic definition]
Union[List["Model"], "_Model", Primitive], # type: ignore[misc]
"A basic model that acts like a `simpleNamespace` "
"or a collection over such models.",
],
Expand Down

0 comments on commit 5a2fdd6

Please sign in to comment.