fix: do not use magic library to discover content type

waylayio · Feb 6, 2024 · 49ffa3a · 49ffa3a
1 parent 9a79d4c
commit 49ffa3a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/src/waylay/sdk/api/rest.py b/src/waylay/sdk/api/rest.py
@@ -82,11 +82,11 @@ async def request(
                 if isinstance(body, BufferedReader):
                     body = body.read()
                 if not headers.get('content-type'):
-                    try:
-                        import magic
-                        mime_type = magic.from_buffer(body)
-                    except BaseException:
-                        mime_type = 'application/octet-stream'
+                    # try:
+                    #     import magic
+                    #     mime_type = magic.from_buffer(body)
+                    # except BaseException:
+                    mime_type = 'application/octet-stream'
                     kwargs['headers'].update({'content-type': mime_type})
                     kwargs.update({'content': body})
             elif content_type and content_type != 'application/json':

diff --git a/test/unit/api/__snapshots__/api_client_test.ambr b/test/unit/api/__snapshots__/api_client_test.ambr
@@ -443,7 +443,6 @@
     'body': b'..some binary content..',
     'files': None,
     'header_params': dict({
-      'Content-Type': 'application/octet-stream',
       'User-Agent': 'waylay-sdk/python/0.0.0',
     }),
     'method': 'POST',
@@ -458,7 +457,7 @@
     ]),
     list([
       tuple(
-        Headers([('host', 'api-example.io'), ('accept', '*/*'), ('accept-encoding', 'gzip, deflate'), ('connection', 'keep-alive'), ('content-type', 'application/octet-stream'), ('user-agent', 'waylay-sdk/python/0.0.0'), ('content-type', 'application/octet-stream'), ('content-length', '23'), ('authorization', '[secure]')]),
+        Headers({'host': 'api-example.io', 'accept': '*/*', 'accept-encoding': 'gzip, deflate', 'connection': 'keep-alive', 'user-agent': 'waylay-sdk/python/0.0.0', 'content-type': 'application/octet-stream', 'content-length': '23', 'authorization': '[secure]'}),
         b'..some binary content..',
       ),
     ]),

diff --git a/test/unit/api/api_client_test.py b/test/unit/api/api_client_test.py
@@ -91,7 +91,6 @@ def waylay_api_client(waylay_config: WaylayConfig) -> ApiClient:
         'method': 'POST',
         'resource_path': '/service/v1/bar/foo',
         'body': b'..some binary content..',
-        'header_params': {'Content-Type': 'application/octet-stream'},
     },
     'form': {
         'method': 'POST',