Initial Map Loading #668
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| import { REGION_TYPES } from '../../util/constants'; | ||
|
|
||
| class MapboxManager { | ||
| // @param {mapboxgl.Map} markerRef: a mapboxgl.Map() object | ||
| // See https://docs.mapbox.com/mapbox-gl-js/api/map/ | ||
| // map is expected to be nullable initially while map.js creates the mapboxgl.Map() object. | ||
| // Mostly serves as a way to pass in a mock in tests | ||
| constructor(map) { | ||
| this.map = map; | ||
| this.mapLoadPromise = new Promise((resolve) => { | ||
| this.onMapLoad = resolve; | ||
| }); | ||
| } | ||
|
|
||
| setMap(map) { | ||
| this.map = map; | ||
| this.onMapLoad(); | ||
| } | ||
|
|
||
| getCenter() { | ||
| if (!this.map) { | ||
| return; | ||
| } | ||
|
|
||
| return this.map.getCenter(); | ||
| } | ||
|
|
||
| // @param {LngLatLike} coords: See https://docs.mapbox.com/mapbox-gl-js/api/geography/#lnglatlike | ||
| // (LngLat | {lng: number, lat: number} | {lon: number, lat: number} | [number, number]) | ||
| async setCenter({ coords, regionType }) { | ||
| if (!coords) { | ||
| throw new Error('No coordinates specified in setCenter'); | ||
| } | ||
|
|
||
| await this.await_map_loaded(); | ||
|
|
||
| // We currently just take the first element in place_type if array | ||
| // FIXME: We should choose either the smallest or largest region type instead | ||
| if (Array.isArray(regionType)) { | ||
| regionType = regionType[0]; | ||
| } | ||
|
|
||
| const zoomLevel = this._getZoom(regionType); | ||
| if (zoomLevel) { | ||
| this.map.flyTo({ | ||
| center: coords, | ||
| zoom: zoomLevel, | ||
| }); | ||
| } else { | ||
| this.map.flyTo({ | ||
| center: coords, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| _getZoom(regionType) { | ||
| switch (regionType) { | ||
| case REGION_TYPES.COUNTRY: | ||
| return 4.5; | ||
| case REGION_TYPES.REGION: | ||
| return 6; | ||
| case REGION_TYPES.PLACE: | ||
| case REGION_TYPES.DISTRICT: | ||
| case REGION_TYPES.POSTAL_CODE: | ||
| return 12; | ||
| case REGION_TYPES.NEIGHBORHOOD: | ||
| case REGION_TYPES.LOCALITY: | ||
| return 14; | ||
| case REGION_TYPES.ADDRESS: | ||
| case REGION_TYPES.LATLONG: | ||
| case REGION_TYPES.POI: | ||
| return 17; | ||
| default: | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| // @param {RefObject} markerRef: ref to a mapboxgl.Marker() object | ||
| // See https://docs.mapbox.com/mapbox-gl-js/api/markers/#marker#addto | ||
| async addMarkerRefToMap(markerRef) { | ||
| await this.await_map_loaded(); | ||
| markerRef.current.addTo(this.map); | ||
| } | ||
|
|
||
| async await_map_loaded() { | ||
| if (!this.map) { | ||
| await this.mapLoadPromise; | ||
| } | ||
|
|
||
| if (!this.map) { | ||
| throw new Error("Something went wrong. Couldn't load map."); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export default MapboxManager; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import MapboxManager from './MapboxManager'; | ||
| import React, { createContext } from 'react'; | ||
|
|
||
| export const MapboxManagerContext = createContext(undefined); | ||
|
|
||
| const mapboxManager = new MapboxManager(); | ||
|
|
||
| const MapboxManagerProvider = ({ children }) => { | ||
| return ( | ||
| <MapboxManagerContext.Provider value={mapboxManager}> | ||
| {children} | ||
| </MapboxManagerContext.Provider> | ||
| ); | ||
| }; | ||
|
|
||
| export default MapboxManagerProvider; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah crap, just realized there's a bug in here in that this query will be repeated after the default cache/stale time runs out. If that happens, the map will be recentered at seemingly random times.
Maybe an alternative is having a hook for doing something just once after all conditions pass lol. Seems hacky but better than having a bunch of
isInitiatedflags laying around