Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 404 Error Page Redesign #476 and #480 #665

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zhiyanz
Copy link

@zhiyanz zhiyanz commented Apr 19, 2023

Tickets: #476 and #480

What has changed:

  • Completed the redesign of the 404 error page for both desktop and mobile
  • Updated SCSS with new fonts and graphic

Screenshots:

Screenshot 2023-04-18 at 10 39 52 PM
Screenshot 2023-04-18 at 10 40 19 PM

@zhiyanz zhiyanz requested review from zoobot and ri0nardo April 19, 2023 02:52
@reviewify-code-review
Copy link

No issues detected, please do a thorough human review.

@@ -1,80 +1,119 @@
.not-found {
.not-found-page {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an article about sass nesting to control scope if you want to go that route
https://css-tricks.com/using-sass-control-scope-bem-naming/

Here's some examples in our code base of what it looks like:
https://github.com/waterthetrees/wtt_front/blob/main/client/src/components/Button/Button.scss

background-color: #EEEEEE;
}

@media (max-width: 900px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the media query breakpoints we've been using:

320px — 480px: Mobile devices
481px — 768px: iPads, Tablets
769px — 1024px: Small screens, laptops
1025px — 1200px: Desktops, large screens
1201px and more —  Extra large screens, TV

Copy link
Member

@zoobot zoobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for making this happen!!

Added a few minor css change requests.
Also, if you can please add a test, that will be great!

Here's an simple example of a snapshot test:
https://github.com/waterthetrees/wtt_front/blob/main/client/src/tests/WttButton.test.js

More test examples here:
https://github.com/waterthetrees/wtt_front/blob/main/client/src/tests

Feel free to either put it in the test folder or in this Notfound folder to be closer this page. You can run it like this:
npm test -- -u NotFound.test.js

@zoobot
Copy link
Member

zoobot commented May 2, 2023

Hi @zhiyanz How's this going? Are you still working on this?

@zhiyanz
Copy link
Author

zhiyanz commented May 2, 2023

Hi @zhiyanz How's this going? Are you still working on this?

Hi @zoobot thanks for checking in and for providing the feedback. I'm really busy with my graduate thesis right now so I won't be able to work on it until after May 15... Really sorry for the delay and inconvenience this may have caused.

@zoobot
Copy link
Member

zoobot commented May 2, 2023

Thanks for getting back. No rush on this. If you are still interested in finishing it up after May 15, great thanks!
Otherwise feel free to un-assign yourself.

@zhiyanz
Copy link
Author

zhiyanz commented May 2, 2023

I will continue working on it after May 15. Thanks for your understanding! @zoobot

@ri0nardo
Copy link

ri0nardo commented Jul 9, 2023

@zoobot is this complete?

@zoobot
Copy link
Member

zoobot commented Jul 9, 2023

@zoobot is this complete?

I am not sure. @zhiyanz Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants