Enable RO0D to be dynamic #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rop pack needs get_material_density_terms
|
As per @adam-a-a, we should wait to merge this until a prototype of the relevant dynamic model(s) has been implemented. |
adam-a-a
changed the title
5 tasks
…tertap into dynamic-exploratory2
…tertap into dynamic-exploratory2
…solver iterations; also replacing aeration tank on bsm2-p instead of cstr_injection with flowsheet level vars and constraints
… BSM2-P solver iterations; also replacing aeration tank on bsm2-p instead of cstr_injection with flowsheet level vars and constraints" This reverts commit bd2caa8.
adam-a-a
approved these changes
Oct 24, 2024
luohezhiming
approved these changes
Oct 30, 2024
| time_nfe = len(m.fs.time) - 1 | ||
| TransformationFactory("dae.finite_difference").apply_to( | ||
| m.fs, nfe=time_nfe, wrt=m.fs.time, scheme="BACKWARD" | ||
| ) |
There was a problem hiding this comment.
It might be better to add this as a config option in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves: Membrane and RO modules being forced to be steady-state.
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
At the moment,
dynamicandhas_holdupterms are hardcoded to beFalsein the membrane channel base class and RO 0D class. I have changed them to be allowed to beBooland inherit from the model declaration.Changes proposed in this PR:
dynamicandhas_holdupdomains toBoolinwatertap/core/membrane_channel_base.pydynamicandhas_holdupin_add_feed_side_membrane_channel_and_geometrymethod ofwatertap/unit_models/reverse_osmosis_0D.pyto inherit fromself.configLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: