-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pydantic 2 failures #1089
Fix Pydantic 2 failures #1089
Conversation
It actually looks like that Pydantic is pinned to 1.10 by |
313eaf3
to
9e5cc7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 325 325
Lines 31701 31701
=======================================
Hits 30287 30287
Misses 1414 1414 ☔ View full report in Codecov by Sentry. |
Fixes/Resolves:
Failures due to breaking changes in Pydantic 2 (used by
watertap.ui.fsapi
).Changes proposed in this PR:
<2
constraint to pydantic requirementLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: