Update README.md #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyyt1013
requested changes
Aug 27, 2020
There was a problem hiding this comment.
good catch :) while you're at it, could you help replace the one-liner with a code block to make it less confusing? see suggestion below @Maxusmusti
| @@ -4,8 +4,9 @@ This project was bootstrapped with [Create React App](https://github.com/faceboo | |||
|
|
|||
| 1. Clone this repo. | |||
| 2. If you have not done so, locally install yarn, node, and python 3.7. (Recommended: using Homebrew) | |||
| 3. Go to the root directory of the project, and set up the local virtual environment by the following commands: `pipenv --python 3.7 && pipenv install`. | |||
| 4. Install node dependencies with yarn: `yarn install --frozen-lockfile`. | |||
| 3. Go to the root directory of the project, and set up the local virtual environment by the following commands: `pipenv --python 3.7 && pipenv install | |||
There was a problem hiding this comment.
Suggested change
| 3. Go to the root directory of the project, and set up the local virtual environment by the following commands: `pipenv --python 3.7 && pipenv install | |
| 3. Go to the root directory of the project, and set up the local virtual environment by the following commands: ``` | |
| $ pipenv --python 3.7 | |
| $ pipenv install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Readme update
Proposed changes
One more instruction
(Optional) Dependencies
Reviewers