entrypoint: enable configuring PHP memory limit #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an environment variable, PHP_MEMORY_LIMIT, which overrides the default memory limit as shipped by PHP. Closes wallabag#124
j0k3r
reviewed
Aug 28, 2023
Updates the readme with documentation for the new PHP_MEMORY_LIMIT environment variable
|
@j0k3r Added documentation to the README; sorry I didn't notice it should be there! |
j0k3r
approved these changes
Sep 1, 2023
|
Hi, first off 👍 for this change (that actually would allow me to re-fetch some of my entries as they systematically blow the memory limit up). Naive question but, any update on merging this PR ? |
Kdecherf
reviewed
Oct 5, 2023
There was a problem hiding this comment.
I'm not a big fan of sed-ing the php.ini file as there are other ways to override php configuration settings.
For example we could add a file 99-wallabag.ini in /etc/php81/conf.d/
/var/www/wallabag # echo memory_limit=256M > /etc/php81/conf.d/99-wallabag.ini
/var/www/wallabag # php -i | grep -i memory
Zend Memory Manager => enabled
memory_limit => 256M => 256M
Collecting memory statistics => No
Kdecherf
added a commit
that referenced
this pull request
Mar 10, 2024
Supersedes #374 Fixes #124 Signed-off-by: Kevin Decherf <[email protected]>
Kdecherf
added a commit
that referenced
this pull request
Mar 11, 2024
Supersedes #374 Fixes #124 Signed-off-by: Kevin Decherf <[email protected]>
|
Superseded by #403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an environment variable,
PHP_MEMORY_LIMIT, which overrides the default memory limit as shipped by PHP.This environment variable, if specified, should be in the format normally expected by PHP (such as 256M or 1G). If unspecified, it defaults to the memory limit specified in php.ini at time of writing, which is 128M. If desired, a more specific default value can be chosen.
Supercedes #125
Supercedes #166
Closes #124