-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing protected-topic cli flag #3160
Conversation
You can find the image built from this PR at
Built from b7a4b4c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to clean this up too but I think we need to perform some previous work to adapt the current status
fleets' configurations and maybe use protected-shards
instead:
https://github.com/status-im/infra-status/blob/d319a1e405cdf1ca18b60d2a2fd19ff629d18194/ansible/group_vars/store.yml#L30-L33
Ooh good catch! I think it's just a matter of adding the new variable to the infra repo and use the new format, shouldn't be an issue I think. Or is there a longer process to follow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for it!
Description
Removing protected-topic CLI flag
Issue
closes #2984