Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: decouple API from go-waku #1239

Merged
merged 2 commits into from
Oct 15, 2024
Merged

refactor: decouple API from go-waku #1239

merged 2 commits into from
Oct 15, 2024

Conversation

richard-ramos
Copy link
Member

Since the integration with nwaku is being done thru status-go, I did a refactor over part of the api package so status-go can implement some interfaces that would let it invoke nwaku's bindings instead of using go-waku directly.
To make the change transparent for status-go while we continue using go-waku, some of the code I extracted is provided as a default implementation.

cc: @gabrielmer @Ivansete-status

@status-im-auto
Copy link

status-im-auto commented Oct 14, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0c12367 #1 2024-10-14 21:19:54 ~2 min unknown 📄log
✔️ 01880d3 #2 2024-10-15 18:49:24 ~2 min unknown 📄log

kaichaosun
kaichaosun approved these changes Oct 15, 2024
View reviewed changes
waku/v2/api/common/result.go Outdated Show resolved Hide resolved
waku/v2/api/publish/message_check.go Outdated Show resolved Hide resolved
chaitanyaprem
chaitanyaprem approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are addressed.

waku/v2/api/common/result.go Outdated Show resolved Hide resolved
waku/v2/api/missing/default_requestor.go Outdated Show resolved Hide resolved
waku/v2/api/missing/missing_messages.go Outdated Show resolved Hide resolved
waku/v2/api/publish/default_publisher.go Show resolved Hide resolved
waku/v2/api/publish/default_publisher.go Show resolved Hide resolved
waku/v2/api/publish/default_publisher.go Outdated Show resolved Hide resolved
@richard-ramos richard-ramos mentioned this pull request Oct 15, 2024
Open
@richard-ramos richard-ramos merged commit 37f936d into master Oct 15, 2024
11 of 12 checks passed
@richard-ramos richard-ramos deleted the decouple-api branch October 15, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@kaichaosun kaichaosun kaichaosun approved these changes

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richard-ramos @status-im-auto @kaichaosun @chaitanyaprem