Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synced unpublish, delete and move for pages #551

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Apr 4, 2022

This replaces #537 (and addresses #15)

wagtail/wagtail#7984 / wagtail/wagtail#7592

To run tests locally:

tox -e python3.8-django4.0-wagtailsync-sqlite wagtail_localize.tests.test_synctree.TestConstructSyncedPageTreeListHook

To-Do:

  • Decide what to do with multi-layered locale sync (fr-ca synchs from fr which syncs from en) -> YES
  • add a global setting to enable/disable this functionality (ref) -> let's make it a setting for opt-in
  • decide whether we support per-model overrides (ref) --> not to per model
  • support multi-layered sync
  • documentation

@zerolab zerolab requested a review from kaedroho April 12, 2022 11:57
@zerolab zerolab marked this pull request as draft April 14, 2022 16:13
@codecov-commenter
Copy link

Codecov Report

Merging #551 (23b2d72) into main (7d6278c) will decrease coverage by 0.38%.
The diff coverage is 4.16%.

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   91.44%   91.06%   -0.39%     
==========================================
  Files          47       47              
  Lines        3894     3918      +24     
  Branches      591      601      +10     
==========================================
+ Hits         3561     3568       +7     
- Misses        192      207      +15     
- Partials      141      143       +2     
Impacted Files Coverage Δ
wagtail_localize/wagtail_hooks.py 71.00% <4.16%> (-9.12%) ⬇️
wagtail_localize/components.py 82.69% <0.00%> (-1.93%) ⬇️
wagtail_localize/models.py 95.57% <0.00%> (-0.15%) ⬇️
wagtail_localize/views/convert.py 71.62% <0.00%> (+1.35%) ⬆️
wagtail_localize/views/edit_translation.py 85.44% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6278c...23b2d72. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants