Allow fields to be explicitly excluded from serialization/deserialization #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
feature/exclude-fields-from-revisions
branch
from
b4dab2c
to
4e185ad
Compare
…zable_data() to accept exclude_fields and pass it on to the model_from_serializable_data() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
It's very common in Wagtail projects to have models with fields that fall into both categories of:
Always including every field in the serialization/deserialization process adds unnecessary overhead in cases where a model's
with_content_json()method will override the value anyway. There's practically zero value in having these values be included in revision content either, as they will always be ignored, and just adds to the overhead of loading/converting revision content from the database.