Add new custom block "DetailsBlock" with expanding answers and demonstrate it in a BreadPage and in a new FAQ page. #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss, and create details_block.html template
…nner field. Demonstrate this in the StandardPage model, with 'questions' field. Update the standard_page.html
…e new FAQ page visible in the top menu.
lb-
requested changes
Jun 26, 2023
| details_block = DetailsBlock() | ||
|
|
||
|
|
||
| # StreamBlocks for Details |
There was a problem hiding this comment.
This is probably not needed, you can use a single block easily with StreamField
There was a problem hiding this comment.
So you suggest not adding the DetailsBlock option to the "old" BaseStreamBlock , just to the "new" DetailsStreamBlock that I created?
| "organisation_url": "https://wagtail.org/" | ||
| "twitter_url": "", | ||
| "github_url": "", | ||
| "organisation_url": "" |
There was a problem hiding this comment.
I don't think this removal is intentional.
| } | ||
| }, | ||
| { | ||
| "model": "wagtailsearchpromotions.querydailyhits", |
There was a problem hiding this comment.
I don't think we need to add these to the fixtures
| <div class="details-content"> | ||
| {{ self.content }} | ||
| </div> | ||
| </details> |
There was a problem hiding this comment.
Please add a line break at the end of this file.
|
@gzark1 can you close this PR if the newer one is preferred |
|
Closing in favour of #425. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lb- suggested adding a
DetailsBlockto showcase a custom block with its own HTML template. TheDetailsBlockincludes three fields:summary(CharField),content(RichTextField), andopen(BooleanField, defaulting to open). This block is ideal for creating an FAQ page with expanding answers and allows for the use of semantic and modern HTML.Changes Made:
DetailsBlockclass inheriting fromStructBlockwith the specified fields.DetailsBlockto the StreamField used by other pages for their content, providing them with the option to include a details block.details_block.html, for rendering theDetailsBlock.DetailsBlocksummary and content in the main CSS file.DetailsBlockin a bread page.DetailsBlockoption, showcased in a newFAQpage of theStandardPagetype.Created sample data for both the bread page and the FAQ page, stored in
bakerydemo/base/fixtures/bakerydemo.json.Added the
FAQpage to the navigation menu.