Make keyset size independent of 'hiding' param #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain::hiding
is used to control whether we want to make the proof zk (or not) by randomizing (or not) the last 3 evaluations of the domain.Currently, setting this parameter to
false
has the side effect of using the 3 zk-rows to make space for 3 extra items in the keyset part.This results in the inability to verify a proof that was generated with
hiding = false
in a verifier domain wherehiding = true
(even though this parameter is not really relevant in the verifier's context).My point is that it would be nice to have, given a certain domain size, a fixed size for the keyset part (regardless of whether hiding is being true or not).
This would also have the added benefit of allowing this parameter (set to
false
) to be leveraged for producing test vectors as well.