Make 'hiding=true' the default

common/src/domain.rs

@@ -56,10 +56,7 @@ pub struct Domain<F: FftField> {
 
 impl<F: FftField> Domain<F> {
     /// Construct a new evaluation domain.
-    ///
-    /// `hiding` parameter determines whether we wish to produce a zk-PROOF or not.
-    /// This parameter is only relevant for the prover.
-    pub fn new(n: usize, hiding: bool) -> Self {
+    pub fn new(n: usize) -> Self {
         let domains = Domains::new(n);
         let size = domains.x1.size();
         let capacity = size - ZK_ROWS;
@@ -76,7 +73,7 @@ impl<F: FftField> Domain<F> {
 
         Self {
             domains,
-            hiding,
+            hiding: true,
             capacity,
             not_last_row,
             l_first,
@@ -85,6 +82,15 @@ impl<F: FftField> Domain<F> {
         }
     }
 
+    /// Set whether we wish to produce a zk-PROOF or not.
+    ///
+    /// Defaults to `true` and this is only relevant for the prover.
+    pub fn hiding(mut self, value: bool) -> Self {
+        self.hiding = value;
+        self
+    }
+
+
     pub(crate) fn divide_by_vanishing_poly<>(
         &self,
         poly: &DensePolynomial<F>,
@@ -228,7 +234,7 @@ mod tests {
 
         // let domain = GeneralEvaluationDomain::new(1024);
         let n = 1024;
-        let domain = Domain::new(n, hiding);
+        let domain = Domain::new(n).hiding(hiding);
         let z = Fq::rand(rng);
         let domain_eval = EvaluatedDomain::new(domain.domain(), z);
         assert_eq!(domain.l_first.poly.evaluate(&z), domain_eval.l_first);

common/src/gadgets/inner_prod.rs

@@ -104,7 +104,7 @@ mod tests {
 
         let log_n = 10;
         let n = 2usize.pow(log_n);
-        let domain = Domain::new(n, hiding);
+        let domain = Domain::new(n).hiding(hiding);
 
         let a = random_vec(domain.capacity - 1, rng);
         let b = random_vec(domain.capacity - 1, rng);
@@ -130,4 +130,4 @@ mod tests {
         _test_inner_prod_gadget(false);
         _test_inner_prod_gadget(true);
     }
-}
+}

common/src/gadgets/sw_cond_add.rs

@@ -266,7 +266,7 @@ mod tests {
 
         let log_n = 10;
         let n = 2usize.pow(log_n);
-        let domain = Domain::new(n, hiding);
+        let domain = Domain::new(n).hiding(hiding);
         let seed = SWAffine::generator();
 
         let bitmask = random_bitvec(domain.capacity - 1, 0.5, rng);

ring/src/lib.rs

@@ -122,7 +122,7 @@ mod tests {
         let setup_degree = 3 * domain_size;
         let pcs_params = CS::setup(setup_degree, rng);
 
-        let domain = Domain::new(domain_size, true);
+        let domain = Domain::new(domain_size);
         let h = SWAffine::rand(rng);
         let seed = find_complement_point::<BandersnatchConfig>();
         let piop_params = PiopParams::setup(domain, h, seed);

ring/src/piop/params.rs

@@ -107,7 +107,7 @@ mod tests {
         let rng = &mut test_rng();
         let h = SWAffine::rand(rng);
         let seed = SWAffine::rand(rng);
-        let domain = Domain::new(1024, false);
+        let domain = Domain::new(1024).hiding(false);
         let params = PiopParams::<Fq, BandersnatchConfig>::setup(domain, h, seed);
         let t = Fr::rand(rng);
         let t_bits = params.scalar_part(t);

ring/src/ring.rs

@@ -259,7 +259,7 @@ mod tests {
         // piop params
         let h = SWAffine::rand(rng);
         let seed = SWAffine::rand(rng);
-        let domain = Domain::new(domain_size, true);
+        let domain = Domain::new(domain_size);
         let piop_params = PiopParams::setup(domain, h, seed);
 
         let mut ring = TestRing::empty(&piop_params, srs, ring_builder_key.g1);
@@ -290,7 +290,7 @@ mod tests {
         // piop params
         let h = SWAffine::rand(rng);
         let seed = SWAffine::rand(rng);
-        let domain = Domain::new(domain_size, true);
+        let domain = Domain::new(domain_size);
         let piop_params = PiopParams::setup(domain, h, seed);
 
         let ring = TestRing::empty(&piop_params, srs, ring_builder_key.g1);