-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOT Login #2175
DOT Login #2175
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application, @singkeo. I have yet to read the proposal thoroughly, but some basic questions in advance:
- Do you have any data on your target audience? Usually, similar projects - even if in different ecosystems - can provide some insight into who needs/uses a product and how large its potential userbase is.
- Are you aware of https://futures.web3.foundation/? It sounds like your project might be a good fit for the program. It's also more flexible in terms of funding mechanisms, something that might be of interest to you.
@semuelle thanks for your quick reply.
We've extended the overview and ecosystem fit chapters to provide more information about our target audience.
Yes, we're aware of it. We've added the reasons for our preference for the grants program to the additional information chapter. I hope this helps to clarify your questions, @semuelle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application @singkeo I have the following comments:
- While I understand the need for middleware to make OAuth 2.0 an option for users who don't have a wallet, I'm not sure I understand the need for yet another web-based wallet. Couldn't there be a way to allow users to connect their existing wallet extension instead?
- How would you compare your project with something like Dauth which uses TEEs for authentication?
- Have you done the research to determine if on-chain JWT validation is feasible and won't create too much overhead vs an off-chain solution? Is there a similar solution in other ecosystems?
We've originally intended to create our own wallet due to the following reasons:
However, after re-consideration we're willing to finance the wallet for this stage by ourself, if you think it doesn't add value to the ecosystem.
To be honest, we were not aware of this project before your comment; thanks for bringing this up. We've added a section dedicated to the comparisons between the two projects. In essence, it seems like they're not building on EVM-tech rather than Polkadot SDK-related tooling while DOT Login is a Substrate-first solution. There are also design differences, e.g. they seem to require the TEE to guarantee the safety of the mail <-> address mapping they're storing there, while our solution doesn't foresee the storage of any PID.
We don't anticipate the JWT validation itself to be expensive since signature validation is a task that collators already heavily are involved with. For example, parachain collators would usually validate transaction signatures or parachain block signatures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @singkeo.
While I have no doubt that you have the technical abilities to implement such a complex project, I am somewhat skeptical about its fit for the grants program. The architecture is fairly complex (requiring a pallet to generate a keypair) and mainly useful only as a whole. What I would suggest is to apply for a smaller grant here and then apply with an extended roadmap at the Decentralized Futures program. That way, you could fund the first month or two of development, and then the wallet as well and possibly more than mentioned here through the DF. Projects were already approved at the DF, it's just not public yet. Also, there are many teams applying there without a clear road to further funding and instead make a case that the treasury should fund further development.
FYI, for more info on DAuth, you can check their recent milestone delivery: w3f/Grant-Milestone-Delivery#1105
@semuelle thanks for your reply. I've removed M2 and M3 from the scope of this grant. Does this setup work better for you? Financing the remaining scope through the DF program sounds like a good option indeed. |
@semuelle I noticed that the changes requested label is still active, so I wanted to check if there's anything missing from our side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @singkeo and sorry for the delay. The reduced scope looks good, however imo the rate seems a bit high for 1 month with 3 FTE. Would you possibly be willing to lower your daily rate a bit?
@keeganquigley no problem, and thanks for the positive feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@singkeo from a tech perspective this looks quite interesting and potentially very useful. I was wondering about the plans for your currently active ventures - will you be able to allocate enough time to this additional project, during the development but also after completing the grant? For context: We've had grantees in the past that abandoned their project after completing the grant which is something we'd like to avoid.
@takahser regarding allocating enough time to this project, please allow me to quote from the grant application:
We're currently shifting our focus to this project. I've already entrusted people close to me with governing and running my current ventures for the month of February, so this has been dealt with. Likewise, my colleagues have temporary reserved most of February for this project, so an allocation of 3 FTE is to be expected. After that, the plan is to secure follow-up funding for the other milestones through the Decentralized Futures program (as suggested by @semuelle), so our focus is going to remain on this project. As you can see in the Milestone 4+ section, we do already have plans beyond that scope, and we're confident to be able to secure long-term funding once the initial 3 milestones have been implemented. I hope this clarifies your doubts, but if not, please don't hesitate to reach out again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@singkeo sounds good, thanks for the clarification. I'm adding my approval and have marked it as ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @singkeo for the changes and the explanations. I'm willing to go forward with it as well.
While waiting for others to comment, we also recently integrated KYC/KYB checks for all potential grantees. Could you please provide the information outlined under this link? Let me know if you have any questions or issues!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. Are you aware of https://github.com/pioneersprize/Polkadot-Pioneers-Prize/blob/main/applications/zklogin-Reclaim-protocol.md How is your solution different? What is the reason that your Github accounts seem rather new and unused? And have you considered applying via the decentralized futures program instead and getting the entire project funded: https://futures.web3.foundation/
@Noc2 thanks for your reply, let me break down your questions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to give it a chance.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
@singkeo, if you haven't yet, could you submit your company information through the KYB link above? |
pinging @singkeo have you completed KYC yet? Thanks. |
Thanks for onboarding us ! @semuelle thanks for the link, @keeganquigley done it today, waiting for the review. |
Project Abstract
DOT Login uses OAuth2 and zk-SNARKs to bridge the gap between Web2 and Web3. This integration is facilitated by a series of custom Substrate pallets, the existing FRAME balances pallet, an off-chain worker that connects to the OAuth2 provider's JWK registry as well as a web-based wallet. DOT Login users will be able to create a wallet using their web2-native OAuth2 account of choice (e.g. Gmail), avoiding common ux painpoints such as remembering keyphrases, learning how to use hardware wallets, etc. without compromising on wallet functionality.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)