Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vane-network #2052

Closed
wants to merge 23 commits into from
Closed

vane-network #2052

wants to merge 23 commits into from

Conversation

MrishoLukamba
Copy link

@MrishoLukamba MrishoLukamba commented Oct 15, 2023

Project Abstract

vane-network a polkadot native tokenless parachain that help social-commerce businesses grow, foster trust-less interactions and enabling transaction safety in web3.

vane helps existing social-commerce entrepreneuers to use web3 based services on top of large existing networks such as Polkadot and Ethereum and allowing crypto users to transact DOT, USDT, ETH in a risk free system.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or Polkadot (USDC & USDT) or BTC address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MrishoLukamba
Copy link
Author

I have read and hereby sign the Contributor License Agreement.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. Regarding the deliveries, could you focus on the specific features that you want to develop that currently don't exist? For example, it's not clear to me how your vane XCM transfer pallet differs from existing solutions. In general, the more technical details you can provide as part of the specification, the better. Additionally, for example, the video link under development status currently points to https://github.com/w3f/Grants-Program/tree/master/applications

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Oct 16, 2023
@dsm-w3f dsm-w3f self-assigned this Oct 19, 2023
Copy link
Contributor

@dsm-w3f dsm-w3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrishoLukamba thank you for the grant application. I agree with David that the application needs more details on the difference between what already exists and what you are proposing. Additionally, I think the calculation of total FTE and duration between the milestones and the total of the grant are not right. The audio of your video demo is very difficult to listen and the pages provided also have broken links. Please double-check this item as well.

@MrishoLukamba
Copy link
Author

@dsm-w3f @Noc2 , Yes am preparing docs for clarification as the naming are same but everything is implemented different i think I will clarify on that. And thanks for the feedback

@MrishoLukamba
Copy link
Author

MrishoLukamba commented Oct 22, 2023

@Noc2 @dsm-w3f Updated the application

@MrishoLukamba
Copy link
Author

@MrishoLukamba thank you for the grant application. I agree with David that the application needs more details on the difference between what already exists and what you are proposing. Additionally, I think the calculation of total FTE and duration between the milestones and the total of the grant are not right. The audio of your video demo is very difficult to listen and the pages provided also have broken links. Please double-check this item as well.

Updated the changes @dsm-w3f

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application @MrishoLukamba. It looks interesting. However, the formatting of the delivery tables is still off. It should be a list format like in the template.

Can you adjust it to fix the numbering? If its easier, some of the info can be moved to the application body and then you can link to it.

@MrishoLukamba
Copy link
Author

MrishoLukamba commented Oct 25, 2023

Thanks for the application @MrishoLukamba. It looks interesting. However, the formatting of the delivery tables is still off. It should be a list format like in the template.

Can you adjust it to fix the numbering? If its easier, some of the info can be moved to the application body and then you can link to it.

Formatted the milestones, hopefully they are readable now. @Noc2 @keeganquigley @dsm-w3f

@dsm-w3f dsm-w3f removed their assignment Oct 27, 2023
@keeganquigley keeganquigley self-assigned this Oct 27, 2023
@MrishoLukamba
Copy link
Author

Changes have been addressed
@keeganquigley @Noc2 @dsm-w3f.

@keeganquigley
Copy link
Contributor

Thanks for the changes @MrishoLukamba Tanssi is super cool and I'm glad you want to utilize it, but the benefits of this parachain still aren't clear to me. How is your solution more risk-free than existing methods?

  • I understand your frustrations around XCM transfers getting stuck, but these issues are usually compatibility issues that are resolved by the parachain team. The transfers at least stay permissionless. I'm not sure that a "permissioned pallet" is the right solution, because wouldn't this infer that trust in Vane is needed?

@MrishoLukamba
Copy link
Author

Thanks for the changes @MrishoLukamba Tanssi is super cool and I'm glad you want to utilize it, but the benefits of this parachain still aren't clear to me. How is your solution more risk-free than existing methods?

  • I understand your frustrations around XCM transfers getting stuck, but these issues are usually compatibility issues that are resolved by the parachain team. The transfers at least stay permissionless. I'm not sure that a "permissioned pallet" is the right solution, because wouldn't this infer that trust in Vane is needed?

Thanks for the queestion @keeganquigley. Vane is not solving XCM infra or improving XCM infra. Vane is a solution which act as an extension safety and product layer on Polkadot and AssetHub for now. What Vane is trying to solve is users can have the ability to transfer their DOT, USDT & USDC in a risk free manner, as small mistakes should not cost crypto users.
As this problem of wrong address transfers and humanely mistakes when doing transactions have hindered lots of new users to try using crypto as there is no a safety net for users.

Apart from that we are trying to build products that utilize trustless interaction such as improving the social-commerce business using blockchain technology. But vane wont be having the native token instead new users and existing users will use these services using their token ( DOT, USDT, USDC). So vane will just act as an extension product layer on existing blockchain network.

So with all these functionality we will be utilizing XCM. so XCM is a tool for us to enable vane to work as intended. But the tracking of XCM message is to make sure that if anything was to happen we can know how to resolve it based on the latest tracked stage.

We have already been accepted into tanssi pioneers program so launching an appchain will speed our development to product market fit. As we believe vane will be crucial to improve UX, safety and crypto usability accross web2 social-commerce.

In the demo I have shown how a user can use DOT to transfer to receivers address in a risk free manner as there is confirmation of receivers address and reversibility of transaction if the sender did anything wrong. And also in one of the milestone we will develop a Notion template marketplace to showcase how individuals can use DOT, USDT to interact with sellers trustlessly using Vane.

In a nutshell Vane will be the computation of these interaction while the Token will remain to be the existing ones.
@Noc2 @keeganquigley

@MrishoLukamba
Copy link
Author

MrishoLukamba commented Nov 1, 2023

Thanks for the changes @MrishoLukamba Tanssi is super cool and I'm glad you want to utilize it, but the benefits of this parachain still aren't clear to me. How is your solution more risk-free than existing methods?

  • I understand your frustrations around XCM transfers getting stuck, but these issues are usually compatibility issues that are resolved by the parachain team. The transfers at least stay permissionless. I'm not sure that a "permissioned pallet" is the right solution, because wouldn't this infer that trust in Vane is needed?

And also on "permissioned pallet", This is not implemented on XCM as vane is not XCM solution, vane used XCM to achieve the safety and product layer on existing networks ( Polkadot & AssetHub), the permissionless term in the 3rd milestone is used to limit deployment of contract on vane chain. As vane will be extensible product and the extension will be done using smart contracts in a permissioned way as all products extended should and will be based on using vane core features.

Refer to the video demo and project abstract to view the Why of developing vane. NB: It is not an improvement of XCM, it just utilizes XCM. @keeganquigley @Noc2

keeganquigley
keeganquigley previously approved these changes Nov 1, 2023
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the explanations @MrishoLukamba very informative and has helped me to grasp your vision. This definitely sounds like a common-good solution and happy to see you utilizing Tanssi, the Asset Hub, and XCM so I'm willing to give it a shot. I will mark it as ready for review and ping the rest of the committee.

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Nov 1, 2023
@MrishoLukamba
Copy link
Author

Any changes or any clarification request? @Noc2 @dsm-w3f

@semuelle
Copy link
Member

So for just wireframes, is it okey we submit them next week?

Hey @MrishoLukamba. You can add the wireframes to the application now or next week, there is no rush from our side. But as @takahser said, they don't have to be clickable or particularly polished, so don't spend too much time on them. :)

@MrishoLukamba
Copy link
Author

MrishoLukamba commented Dec 15, 2023

So for just wireframes, is it okey we submit them next week?

Hey @MrishoLukamba. You can add the wireframes to the application now or next week, there is no rush from our side. But as @takahser said, they don't have to be clickable or particularly polished, so don't spend too much time on them. :)

Okey and @takahser the wireframe wont include social media integration for now

@github-actions github-actions bot added the stale label Dec 30, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MrishoLukamba. Are you still planning to include wireframes? I can see that you have already made significant progress with the project, they are simply a requirement of any grant application involving UI work. As I said, they don't have to be polished. It seems that you would be well underway to being approved then.

Regarding the ongoing work on the project: it would be great if you could add a paragraph on that in the Development Status section of the grant application. It's currently empty now.

@MrishoLukamba
Copy link
Author

Hi @MrishoLukamba. Are you still planning to include wireframes? I can see that you have already made significant progress with the project, they are simply a requirement of any grant application involving UI work. As I said, they don't have to be polished. It seems that you would be well underway to being approved then.

Regarding the ongoing work on the project: it would be great if you could add a paragraph on that in the Development Status section of the grant application. It's currently empty now.

Okey yes they are coming around and the section of development, We updated concerning our ongoing work in the grant application.

keeganquigley
keeganquigley previously approved these changes Jan 12, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the roadmap @MrishoLukamba re-approving.

@MrishoLukamba
Copy link
Author

MrishoLukamba commented Jan 23, 2024

Thanks for including the roadmap @MrishoLukamba re-approving.

Updates on our end:
I know we have been slow to respond, I am currently finishing PBA, but we will be submitting the wireframes soon.
And will be updating the founders list.

@keeganquigley @semuelle @takahser

@takahser
Copy link
Collaborator

takahser commented Jan 23, 2024

@MrishoLukamba okay, thanks for the note, and no worries about the delay. I know the PBA program can be exhaustive for students, so I suggest to focus on PBA for now. You can add the wireframes after the PBA, feel free to ping us again, once that's done.
Also, I've put the application on hold for the meantime; I'll change it back to ready for review once the wireframes are added. 👍

@takahser takahser added on hold There is an external blocker, such as another grant in progress. and removed ready for review The project is ready to be reviewed by the committee members. labels Jan 23, 2024
@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Feb 7, 2024
@MrishoLukamba
Copy link
Author

MrishoLukamba commented Feb 7, 2024

@MrishoLukamba okay, thanks for the note, and no worries about the delay. I know the PBA program can be exhaustive for students, so I suggest to focus on PBA for now. You can add the wireframes after the PBA, feel free to ping us again, once that's done. Also, I've put the application on hold for the meantime; I'll change it back to ready for review once the wireframes are added. 👍

Added the wireframes for the risk free transaction feature.
@keeganquigley @SBalaguer @takahser @semuelle

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrishoLukamba thanks for adding the wireframes. I've did another iteration and still found some unclarities, please have a look. Also, I'm marking it as ready for review again and ping the rest of the committee.

| **0b.** | Documentation | We will provide both **inline documentation** of the code and a basic **tutorial** that explains how a user can (for example) spin up one of our Substrate nodes and send test transactions, which will show how the new functionality works. |
| **0c.** | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. |
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. |
| 0e. | Video tutorial | We will publish an workshop on X/Twitter that explains [...] (what was done/achieved as part of the grant and how the product should be used) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been addressed yet. Also, there is still some leftover text present that was copied over from the template:

[...] (what was done/achieved as part of the grant and how the product should be used)

| **0c.** | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. |
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. |
| 0e. | Video tutorial | We will publish an workshop on X/Twitter that explains [...] (what was done/achieved as part of the grant and how the product should be used) |
| 1. | pallet transaction claim resolver | We will create a Substrate module that will handle failed transaction based on XCM delivery issues. Allowing users to claim their incomplete transactions|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you outline the supported reasons for xcm delivery failure here?

| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. |
| 0e. | Video tutorial | We will publish an workshop on X/Twitter that explains [...] (what was done/achieved as part of the grant and how the product should be used) |
| 1. | pallet transaction claim resolver | We will create a Substrate module that will handle failed transaction based on XCM delivery issues. Allowing users to claim their incomplete transactions|
| 2. | permissioned pallet contract & chain extensions | A permissioned wasm contract pallet and chain exensions for vane risk free transfer system to be used to extend Vane product services. Account who intend to extend vane product services must apply to be whitelisted to deploy the contract.<br><br>**Chain extensions**<br> This will be limited to vane specific pallets extrinsics only, which includes, pallet_vane_xcm_transfer, pallet_vane_relay_asset, pallet_transfer_claim |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account who intend to extend vane product services must apply to be whitelisted to deploy the contract.

Do you refer to smart contracts here or to some kind of financial contract? If smart contract, does that mean each user has to deploy a smart contract in order to use vane?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No user can extend vane functionalities by deploying a smart contract for an application that uses vane chain extensions and base layer functionality ( risk free and trustless transfers)

| 0e. | Video tutorial | We will publish an workshop on X/Twitter that explains [...] (what was done/achieved as part of the grant and how the product should be used) |
| 1. | pallet transaction claim resolver | We will create a Substrate module that will handle failed transaction based on XCM delivery issues. Allowing users to claim their incomplete transactions|
| 2. | permissioned pallet contract & chain extensions | A permissioned wasm contract pallet and chain exensions for vane risk free transfer system to be used to extend Vane product services. Account who intend to extend vane product services must apply to be whitelisted to deploy the contract.<br><br>**Chain extensions**<br> This will be limited to vane specific pallets extrinsics only, which includes, pallet_vane_xcm_transfer, pallet_vane_relay_asset, pallet_transfer_claim |
| 3. | Notion template marketplace contract| The marketplace will showcase how we can enable transaction customization for social-commerce business and foster growth. It will contain, listing of notion templates, securely limiting access of the notion template, buying of the template, Order placement and tracking.|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I understand correctly - this is a marketplace to trade notion.so templates?
Could you please list the tech used here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, and the tech stack used I listed above. TS, Nest Js, Next Js, Rust Ink Smart contract. ( showcasing extending vane functionality utilizing risk free transfers

| 2. | permissioned pallet contract & chain extensions | A permissioned wasm contract pallet and chain exensions for vane risk free transfer system to be used to extend Vane product services. Account who intend to extend vane product services must apply to be whitelisted to deploy the contract.<br><br>**Chain extensions**<br> This will be limited to vane specific pallets extrinsics only, which includes, pallet_vane_xcm_transfer, pallet_vane_relay_asset, pallet_transfer_claim |
| 3. | Notion template marketplace contract| The marketplace will showcase how we can enable transaction customization for social-commerce business and foster growth. It will contain, listing of notion templates, securely limiting access of the notion template, buying of the template, Order placement and tracking.|
| 4. | Backend (Nest JS) | All chain ( vane, polkadot/rococo, assethub) api interaction implementation, API chart workflow, notion marketplace implementation for storing notion pages, notion users as a POC |
| 5. | Frontend (Next JS) | A front end prototype in Figma, A front end interaction for implemented feature hosted in vercel which will be only for wide screen ( no responsiveness ) as later on (not this grant ) we will implement a mobile application |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 5. | Frontend (Next JS) | A front end prototype in Figma, A front end interaction for implemented feature hosted in vercel which will be only for wide screen ( no responsiveness ) as later on (not this grant ) we will implement a mobile application |
| 5. | Frontend (Next JS) | Front end wireframes in Figma and a NextJs-based front end for the implemented feature hosted in vercel which will be only for wide screen (no responsiveness) as later on (not this grant) we will implement a mobile application |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make it clearer that it's an actual implementation, not just figma wireframes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did mention that it will figma wireframes and the actual front end

| **0c.** | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. |
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. |
| 0e. | Video tutorial | We will publish an workshop on X/Twitter that explains [...] (what was done/achieved as part of the grant and how the product should be used) |
| 1. | Transaction Delivery Tracking System | As vane-risk free transfer system involves the following parts.<br> Relay_chain xcm reserveTransfer to Vane, confirmation of sender and receiver's address,sending xcm instructions to relay/assethub for transacting asset from vane para account to receiver.<br> The following are notable issues which may arrive; Failure to deliver and execute XCM message to vane, and relay/assethub.<br><br> A tracking functionality of where the transaction stuck is essential and will be implemented as a struct of an enum and stored in transaction tracking storage with key of multi_id.<br> The updating will be based on queries of effect of what the transaction is supposed to do using XCM.<br>|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a pallet? Pls specify directly in the doc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is a pallet


- Confirmation and reversible transactions
- Customizable and trustless transactions for social-commerce business
- Native token-less parachain enabling usage of DOT, USDT & USDT for all interactions via XCM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean your solution enables non-native (e.g. USDT) transfers without the necessity to own the native asset? I believe this isn't included in the milestones yet, could you fix that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solutions allows USDT, USDC, DOT to be transferred in a risk free manner

@takahser takahser added ready for review The project is ready to be reviewed by the committee members. and removed on hold There is an external blocker, such as another grant in progress. labels Feb 8, 2024
@MrishoLukamba
Copy link
Author

And also am updating my team

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrishoLukamba, thanks for the updates. After reviewing the application again, I'm thinking it might be a good fit for the Decentralized Futures Program. Have you looked into that? If you are planning to build a fully-fledged product with business model, it's actually a much better fit.

@MrishoLukamba
Copy link
Author

MrishoLukamba commented Feb 12, 2024

@MrishoLukamba, thanks for the updates. After reviewing the application again, I'm thinking it might be a good fit for the Decentralized Futures Program. Have you looked into that? If you are planning to build a fully-fledged product with business model, it's actually a much better fit.

I do believe for our stage web3 grants does make sense more.
We have our POC but we are still tinkering and finding optimal solutions to the problem and the future we want to create.

I do think decentralised futures will be the next step after this completion.
@semuelle

@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Feb 22, 2024
@github-actions github-actions bot added the stale label Mar 8, 2024
@semuelle
Copy link
Member

semuelle commented Mar 8, 2024

Thanks again for the application, @MrishoLukamba, and sorry for the long radio silence. The committee has discussed your proposal and decided not to go forward with it. The main reason being that it thinks the project to be a better fit for the DF program. So, we would like to recommend to apply there. Applications are only open until the end of June, you could always revisit the grants program as an alternative afterwards.

@semuelle semuelle closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants