-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centrifuge TWAMM grant application #1813
Conversation
857a1cb
to
dd879db
Compare
dd879db
to
3f058b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wischli. Thanks for the application, and sorry for the long wait. It looks good to me, so I will share your proposal with the rest of the committee. Thanks for the DCA write-up. I just have some general questions:
- Based on the numbers, you are requesting ~33k USD per person-month, which is about 2.5 the usual rate we see. Is that the actual rate or are the FTEs off?
- Could you summarise the differences between your treasury proposal and this application? I see you left out frontend and audit, but there is still a big difference. Is this due to the
pallet_twamm
deliverable being aPOC
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the application. But I agree with what @semuelle said. We usually pay a lot less for the development of pallets. Especially since the grants program primarily supports the development of a PoC or something similar and not production-ready software. If you want to deploy this on the asset hub, including audits, etc., you need to involve the community at some stage anyway, so it might make sense to immediately apply another time for treasury funding using open gov and potentially a reduced price.
@Noc2 @semuelle We are grateful for the time you've taken to explore our application. Your engagement is genuinely valued! Your constructive feedback regarding our pricing structure has not gone unnoticed. Following your insightful comments, we've undertaken measures to decrease our fundamental hourly rates, while also making minor modifications to the project scope. This strategic move embodies our pledge to uphold a transparent and client-centric business ethos. Our intent is that this modified proposal aligns more closely with your financial parameters and anticipates your requirements. We are steadfast in our dedication to provide the uppermost tier of professional services, ensuring the most efficient use of grant resources.
Following careful consideration and refinement, we have determined it appropriate to present a proposal aligning closely with Milestone 1 of the DOT Treasury proposal, which initially requested funding amounting to $190,000. It is important to emphasize that the DOT proposal also included retroactive funding for the development of the pallet-rewards. However, this component does not form part of the current application as it has been already developed. Furthermore, in order to remain within budgetary constraints, we have chosen to adopt a more optimistic estimation that does not exceed the originally requested $100,000 (now $75,000) for this grant application.
We think merely building a PoC would not have the result of actually building something usable for Polkadot. Our intention is to make this widely available to parachains to allow them as well as the Polkadot treasury directly to diversify their holdings safely without the risk of front running or any centralized trust. As such we want to make sure this pallet is well understood and easy to use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the updates, and sorry for the delay here. I'm happy to go ahead with it and share it with the rest of the team. Apart from this, a reminder to sign the latest version of our terms and conditions above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the price adjustments @wischli quite the lengthy forum post, but I don't have any questions at this point. Based on your reputation and thorough research, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wischli I'm quoting from your comment:
We think merely building a PoC would not have the result of actually building something usable for Polkadot. Our intention is to make this widely available to parachains to allow them as well as the Polkadot treasury directly to diversify their holdings safely without the risk of front running or any centralized trust. As such we want to make sure this pallet is well understood and easy to use.
However, in your proposal you wrote:
| 1. |
pallet_twamm
PoC | Config usingpallet-conversion-rate
as implementor ofBasicAmm
trait, Structs, Storage as above. |
Could you remove the PoC from that deliverable?
Also, while I agree with the overall sentiment that a TWAMM pallet would be very useful I think you're not the first team to approach a TWAMM implementation. For example, FraxFinance has already delivered theirs >1y ago and I also found this TWAMM reference implementation. For translating one of these existing implementations that consist of a couple of functions to Rust/Substrate I think the price point of 75k is not justified. But at the same time I must admit that I don't know a lot about _TWAMM_s, so if I'm missing something here feel free to correct me. :)
Sorry for getting back late, I was away until yesterday. Thanks for spotting the PoC - I've taken it out of the application. On the topic of cost and timing, I just wanted to note that our plan for 7.5 weeks of work with 1.5 full-time team members is what we think will let us deliver a qualitative pallet that's not just a repeat of the same old solidity TWAMM code. We're considering all the tasks involved which includes some retroactive work as well - researching TWAMM and comparing with HydraDX's DCA, writing a detailed spec, setting up the pallet the Substrate way, really getting into the nitty-gritty of the Substrate pallet-asset-conversion implementation (which might include submitting some small PRs), and of course, the necessary documentation. We feel the timeline we've set is totally fair. We thought we were all set with the money stuff, so let's talk if there are any lingering questions. |
0c0eef4
Thank you for presenting the proposal for a comparison article. Your suggestion is indeed well-founded! I have now incorporated it into the list of deliverables. I hope this will address everyone's concerns and preferences. I really appreciate everyone for their valuable input and time dedicated to this matter! |
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
I think this project is a valuable contribution. Adding it to I wonder if the approvers (@Noc2, @takahser, @semuelle, @SBalaguer, @keeganquigley ), might consider asking for the hype to be dialed down in the delivered documentation. Specifically, the advice to Treasuries or others that this is a solution for, protects against, or is otherwise a set-and-forget exercise in the face of front running:
and
I don't read the Paradigm document as claiming a solution to front running. I certainly don't read any claim about optimality. Nor do they claim to eliminate the risk of front running. To my mind, they suggest the opposite. Front running needs to be monitored and manual intervention is required, by canceling the order being front run:
If those "other traders" don't spontaneously comply with these expectations, or you don't cancel your long-term order until they showup. You've been successfully front-run. Also, the Paradigm document is careful not to define "overly aggressive front-runners". They stand in contrast to, I presume, acceptably aggressive front-runners. |
@taqtiqa-mark, I might be missing something, but can you share with me the exact lines in the grant application doc from which you took the quotes? Additionally, everyone has the right to share their opinion/beliefs as part of an application. We mostly care about the concrete open-source deliveries defined in the milestones that are actually the requirements of the contract. Furthermore, to quote the paradigm document on the topic:
|
I don't think so...
They come from the above representations, and can be found in the application: L23:
Agreed.
Yes, I just suggested possibly toning down the hype in the documentation, from anything like what I quoted. Anyone reading the code after a while, will realize that what Paradigm state still applies - you still have to monitor for front running and be ready to cancel your order when it happens at a level you are unhappy with.... the "overly" vs "acceptably" aggressive front running point I made.
Yes, this is the same section I quoted above...
|
Hi @wischli how is the milestone coming along? |
Hi @keeganquigley! Due to recent adjustments in our engineering team's capacity, we have not yet commenced work on this project. Our focus has primarily been on our core product, which we had to prioritize. We anticipate initiating work on the TWAMMs project in the coming weeks. Rest assured, I will provide updates as soon as we reach our targeted milestone. We regret any inconvenience this may have caused and appreciate your understanding. |
Thanks @wischli we understand that delays happen, but in this case, could you please file an amendment to extend the timeline in the milestones? It can be a rough estimate, doesn't have to be exact. But adding a few months should be approved relatively quickly and will allow us to update our records and budget accordingly. Thanks! |
pinging @wischli |
* Centrifuge TWAMM grant application * adjust financials * fix: remove PoC * add twamm 2.0 milestone
Hi @wischli how is progress coming on M1? |
pinging @wischli |
Sorry for the late reply @keeganquigley - your message got buried during my summer vacation. Unfortunately, we haven't had the capacity to work on the first deliverable yet. It looks like we won't be able to get to it before 2025. I'm really sorry for any inconvenience this change in priorities might cause. |
Hi @wischli thanks very much for the update, it is much appreciated. A timeline adjustment like this would require an amendment, but in this case, since the starting date would be more than 6 months out, it's probably best to close the grant for now, and it can potentially be re-opened in the future when you are ready to work on it. The same amount of committee approvals would be needed to re-open it, but we would take your current situation into account. Let me know if this sounds good and we will proceed with closing it for now. Thanks! |
Hi @wischli we will go ahead and close the grant for now since the starting date is over six months out, but feel free to comment here next year if/when you want to re-open it. Thanks. |
Project Abstract
This application aims to implement a Substrate pallet that seamlessly acts as an opt-in extension for the frame
pallet-asset-conversion
. The latter serves as a representation of the upcoming Uniswap-v2 style Decentralized Exchange (DEX), integrated within the Asset Hub. This application can be beneficial to any other Substrate chain seeking a straightforward local chain DEX.Regrettably, the prolonged exchange of large volumes on such DEXes is susceptible to being front-run or subjected to sandwich attacks. We believe that the optimal solution to this predicament is the Time Weighted Automated Market Maker (TWAMM).
Our proposed framework can be incorporated across a variety of Substrate chains, inclusive of the relay chain, aiming to streamline the operations of a simplified Uniswap V2 decentralized exchange. This model effectively mitigates the challenges associated with executing sizeable orders, even within comparatively illiquid markets. It is especially compatible with gradual automated procedures, such as governance-controlled treasury operations, thereby enabling the proficient implementation of a dollar-cost averaging strategy over extended periods. Our recent collaboration on the development of a Multi Asset Treasury has highlighted the necessity of having a non-attackable long-term tokenswap mechanism like TWAMM. Within this context, we have engaged in discussions with the System Parachain team, particularly Joe, who has expressed support for the inclusion of our proposed TWAMM extension onto the Asset Hub
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)